The default bug view has changed. See this FAQ.

remove msgComposeService global variables from mail/base/content

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Mail Window Front End
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 14.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

16.12 KB, patch
Magnus Melin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
hiddenWindow.js:var msgComposeService = Components.classes["@mozilla.org/messengercompose;1"]
hiddenWindow.js:                                  .getService(Components.interfaces.nsIMsgComposeService);
mailCommands.js:  if (!msgComposeService)
mailCommands.js:    dump("### msgComposeService is invalid\n");
mailCommands.js:        msgComposeService.OpenComposeWindow(null, null, null, type,
mailCommands.js:      msgComposeService.OpenComposeWindow(null, null, newsgroup, type,
mailCommands.js:        msgComposeService.OpenComposeWindow(null, hdr, messageArray.join(','),
mailCommands.js:          msgComposeService.OpenComposeWindow(null, hdr, messageUri, type,
mailCommands.js:      msgComposeService.OpenComposeWindowWithParams(null, params);
mailContextMenus.js:  msgComposeService.OpenComposeWindowWithParams(null, params);
mailOverlay.xul:        var msgComposeService = Components.classes["@mozilla.org/messengercompose;1"].getService();
mailOverlay.xul:        msgComposeService = msgComposeService.QueryInterface(Components.interfaces.nsIMsgComposeService);
mailOverlay.xul:        msgComposeService.OpenComposeWindow(null, null, null,
mailWindow.js:var msgComposeService;
mailWindow.js:  msgComposeService = Components.classes['@mozilla.org/messengercompose;1']
mailWindow.js:                                .getService(Components.interfaces.nsIMsgComposeService);
msgHdrViewOverlay.js:  msgComposeService.OpenComposeWindowWithParams(null, params);
(Assignee)

Comment 1

5 years ago
Created attachment 609116 [details] [diff] [review]
patch
Attachment #609116 - Flags: review?(mkmelin+mozilla)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 609124 [details] [diff] [review]
patch v2

Fixes a typo.
Attachment #609116 - Attachment is obsolete: true
Attachment #609116 - Flags: review?(mkmelin+mozilla)
Attachment #609124 - Flags: review?(mkmelin+mozilla)

Comment 3

5 years ago
Comment on attachment 609124 [details] [diff] [review]
patch v2

Review of attachment 609124 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin
Attachment #609124 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/c604f2ff2691
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.