Last Comment Bug 739051 - remove msgComposeService global variables from mail/base/content
: remove msgComposeService global variables from mail/base/content
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 14.0
Assigned To: :aceman
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks: 720358
  Show dependency treegraph
 
Reported: 2012-03-25 04:57 PDT by :aceman
Modified: 2012-03-28 17:38 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (16.12 KB, patch)
2012-03-25 07:10 PDT, :aceman
no flags Details | Diff | Splinter Review
patch v2 (16.12 KB, patch)
2012-03-25 08:47 PDT, :aceman
mkmelin+mozilla: review+
Details | Diff | Splinter Review

Description :aceman 2012-03-25 04:57:15 PDT
hiddenWindow.js:var msgComposeService = Components.classes["@mozilla.org/messengercompose;1"]
hiddenWindow.js:                                  .getService(Components.interfaces.nsIMsgComposeService);
mailCommands.js:  if (!msgComposeService)
mailCommands.js:    dump("### msgComposeService is invalid\n");
mailCommands.js:        msgComposeService.OpenComposeWindow(null, null, null, type,
mailCommands.js:      msgComposeService.OpenComposeWindow(null, null, newsgroup, type,
mailCommands.js:        msgComposeService.OpenComposeWindow(null, hdr, messageArray.join(','),
mailCommands.js:          msgComposeService.OpenComposeWindow(null, hdr, messageUri, type,
mailCommands.js:      msgComposeService.OpenComposeWindowWithParams(null, params);
mailContextMenus.js:  msgComposeService.OpenComposeWindowWithParams(null, params);
mailOverlay.xul:        var msgComposeService = Components.classes["@mozilla.org/messengercompose;1"].getService();
mailOverlay.xul:        msgComposeService = msgComposeService.QueryInterface(Components.interfaces.nsIMsgComposeService);
mailOverlay.xul:        msgComposeService.OpenComposeWindow(null, null, null,
mailWindow.js:var msgComposeService;
mailWindow.js:  msgComposeService = Components.classes['@mozilla.org/messengercompose;1']
mailWindow.js:                                .getService(Components.interfaces.nsIMsgComposeService);
msgHdrViewOverlay.js:  msgComposeService.OpenComposeWindowWithParams(null, params);
Comment 1 :aceman 2012-03-25 07:10:41 PDT
Created attachment 609116 [details] [diff] [review]
patch
Comment 2 :aceman 2012-03-25 08:47:13 PDT
Created attachment 609124 [details] [diff] [review]
patch v2

Fixes a typo.
Comment 3 Magnus Melin 2012-03-28 04:30:10 PDT
Comment on attachment 609124 [details] [diff] [review]
patch v2

Review of attachment 609124 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-03-28 17:38:34 PDT
http://hg.mozilla.org/comm-central/rev/c604f2ff2691

Note You need to log in before you can comment on or make changes to this bug.