Closed
Bug 739072
Opened 12 years ago
Closed 12 years ago
Fix "thoes" spelling
Categories
(Release Engineering :: General, defect, P4)
Release Engineering
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: sgautherie, Assigned: nickyekaiqi)
References
()
Details
Attachments
(2 files, 2 obsolete files)
|
1.60 KB,
patch
|
coop
:
review+
|
Details | Diff | Splinter Review |
|
1.60 KB,
patch
|
Details | Diff | Splinter Review |
Use "those". "Found one matching line"
I am interested in this bug. Seems a little trivial :) But it is a good first bug to learn how to use mxr and creating a patch. So could someone kindly assign it to me?
|
Reporter | |
Comment 2•12 years ago
|
||
(In reply to Ye Kaiqi from comment #1) > could someone kindly assign it to me? You may be able to do it when attaching your patch, otherwise I'll help.
I created the patch wrongly for the last patch. I uploaded a new one
Attachment #610397 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•12 years ago
|
Attachment #610397 -
Attachment description: Do as instruction → Do as instruction
[Whole file]
|
|
Reporter | |
Comment 6•12 years ago
|
||
Comment on attachment 610437 [details] [diff] [review] spelling change patch See https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Attachment #610437 -
Flags: review?(coop)
Attachment #610437 -
Flags: feedback+
|
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → nickyekaiqi
Status: NEW → ASSIGNED
Attachment #610437 -
Attachment is obsolete: true
Attachment #610437 -
Flags: review?(coop)
Attachment #610479 -
Flags: review?
|
|
Reporter | |
Comment 8•12 years ago
|
||
Comment on attachment 610479 [details] [diff] [review] Modified patch following the instruction >Bug 739072 : Change spelling error "thoes" to "those"; r=sgautherie f=sgautherie
Attachment #610479 -
Flags: review? → review?(coop)
|
||
Updated•12 years ago
|
Attachment #610479 -
Flags: review?(coop) → review+
So it has been reviewed? I am quite new to it and want to start other bugs after this one
|
Assignee | |
Comment 10•12 years ago
|
||
Anything else to do with this bug?
|
|
Reporter | |
Comment 11•12 years ago
|
||
(In reply to Ye Kaiqi from comment #9) > So it has been reviewed? Yes. (In reply to Ye Kaiqi from comment #10) > Anything else to do with this bug? Fix comment 8.
|
|
Assignee | |
Comment 12•12 years ago
|
||
|
|
Reporter | |
Updated•12 years ago
|
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=sgautherie][lang=py]
|
||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6990e7e757c3 Thanks for the patch! Feel free to drop in to #developers on irc.mozilla.org if you ever want help finding other bugs to work on.
Keywords: checkin-needed
|
|
Assignee | |
Comment 14•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #13) > https://hg.mozilla.org/integration/mozilla-inbound/rev/6990e7e757c3 > > Thanks for the patch! Feel free to drop in to #developers on irc.mozilla.org > if you ever want help finding other bugs to work on. I was in #developers for several days for the information of another bug! Thanks for your help!
|
||
Comment 15•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6990e7e757c3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•