Closed
Bug 739092
Opened 12 years ago
Closed 12 years ago
Neterror icon behind robot
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 17
People
(Reporter: tanner, Assigned: dcrewi)
Details
Attachments
(1 file, 2 obsolete files)
773 bytes,
patch
|
Details | Diff | Splinter Review |
On about:robots you can see the neterror /!\ icon behind the robot. It's a nice hair style, but orange hair is not fitting for the robot. Screenshot: http://i.imgur.com/06tGm.png
Assignee | ||
Comment 1•12 years ago
|
||
Removing the caution icon is a very simple change.
Assignee | ||
Updated•12 years ago
|
Attachment #649804 -
Flags: review?(dao)
Comment 2•12 years ago
|
||
Jared: Is this handled in bug 756926 already?
Comment 3•12 years ago
|
||
It's handled by the patch for bug 756926, but that looks to be a ways off from landing, so I think it would be fine to take this patch now. Further, we're still not sure how about:robots would look like in the new layout of these pages.
Assignee: nobody → dmc
Status: NEW → ASSIGNED
Comment 4•12 years ago
|
||
Comment on attachment 649804 [details] [diff] [review] remove robot's hair This works, but 'background-image: none' is more explicit and should be sufficient.
Attachment #649804 -
Flags: review?(dao) → review-
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #649804 -
Attachment is obsolete: true
Attachment #653511 -
Flags: review?(dao)
Comment 6•12 years ago
|
||
Comment on attachment 653511 [details] [diff] [review] hairless robots, revised >+ #errorPageContainer { >+ background-image: none; Please replace the tab stop with two spaces. Looks good otherwise. Thanks!
Attachment #653511 -
Flags: review?(dao) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Ah, I didn't even notice the whitespace issue.
Attachment #653511 -
Attachment is obsolete: true
Updated•12 years ago
|
Keywords: checkin-needed
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1f256d6070ac
Keywords: checkin-needed
Target Milestone: --- → Firefox 17
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1f256d6070ac
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•