Last Comment Bug 739092 - Neterror icon behind robot
: Neterror icon behind robot
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: 12 Branch
: All All
: -- trivial (vote)
: Firefox 17
Assigned To: David Creswick
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-25 12:43 PDT by Tanner Filip [:tanner]
Modified: 2012-08-21 11:11 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove robot's hair (773 bytes, patch)
2012-08-07 14:12 PDT, David Creswick
dao+bmo: review-
Details | Diff | Review
hairless robots, revised (772 bytes, patch)
2012-08-20 14:03 PDT, David Creswick
dao+bmo: review+
Details | Diff | Review
hairless robots, revised (773 bytes, patch)
2012-08-20 17:43 PDT, David Creswick
no flags Details | Diff | Review

Description Tanner Filip [:tanner] 2012-03-25 12:43:41 PDT
On about:robots you can see the neterror /!\ icon behind the robot. It's a nice hair style, but orange hair is not fitting for the robot.

Screenshot: http://i.imgur.com/06tGm.png
Comment 1 David Creswick 2012-08-07 14:12:41 PDT
Created attachment 649804 [details] [diff] [review]
remove robot's hair

Removing the caution icon is a very simple change.
Comment 2 Blair McBride [:Unfocused] (mostly unavailable, needinfo open, reviews not) 2012-08-07 22:51:13 PDT
Jared: Is this handled in bug 756926 already?
Comment 3 (Away 6/25-7/4) Jared Wein [:jaws] (reviews and needinfo disabled until back) 2012-08-07 22:58:22 PDT
It's handled by the patch for bug 756926, but that looks to be a ways off from landing, so I think it would be fine to take this patch now. Further, we're still not sure how about:robots would look like in the new layout of these pages.
Comment 4 Dão Gottwald [:dao] 2012-08-10 10:02:21 PDT
Comment on attachment 649804 [details] [diff] [review]
remove robot's hair

This works, but 'background-image: none' is more explicit and should be sufficient.
Comment 5 David Creswick 2012-08-20 14:03:42 PDT
Created attachment 653511 [details] [diff] [review]
hairless robots, revised
Comment 6 Dão Gottwald [:dao] 2012-08-20 14:38:20 PDT
Comment on attachment 653511 [details] [diff] [review]
hairless robots, revised

>+      #errorPageContainer {
>+      	background-image: none;

Please replace the tab stop with two spaces.

Looks good otherwise. Thanks!
Comment 7 David Creswick 2012-08-20 17:43:36 PDT
Created attachment 653599 [details] [diff] [review]
hairless robots, revised

Ah, I didn't even notice the whitespace issue.
Comment 8 Blair McBride [:Unfocused] (mostly unavailable, needinfo open, reviews not) 2012-08-21 00:36:21 PDT
https://hg.mozilla.org/integration/fx-team/rev/1f256d6070ac
Comment 9 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-08-21 11:11:38 PDT
https://hg.mozilla.org/mozilla-central/rev/1f256d6070ac

Note You need to log in before you can comment on or make changes to this bug.