Closed Bug 739092 Opened 12 years ago Closed 12 years ago

Neterror icon behind robot

Categories

(Firefox :: General, defect)

12 Branch
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 17

People

(Reporter: tanner, Assigned: dcrewi)

Details

Attachments

(1 file, 2 obsolete files)

On about:robots you can see the neterror /!\ icon behind the robot. It's a nice hair style, but orange hair is not fitting for the robot.

Screenshot: http://i.imgur.com/06tGm.png
Attached patch remove robot's hair (obsolete) — Splinter Review
Removing the caution icon is a very simple change.
Attachment #649804 - Flags: review?(dao)
Jared: Is this handled in bug 756926 already?
It's handled by the patch for bug 756926, but that looks to be a ways off from landing, so I think it would be fine to take this patch now. Further, we're still not sure how about:robots would look like in the new layout of these pages.
Assignee: nobody → dmc
Status: NEW → ASSIGNED
Comment on attachment 649804 [details] [diff] [review]
remove robot's hair

This works, but 'background-image: none' is more explicit and should be sufficient.
Attachment #649804 - Flags: review?(dao) → review-
Attached patch hairless robots, revised (obsolete) — Splinter Review
Attachment #649804 - Attachment is obsolete: true
Attachment #653511 - Flags: review?(dao)
Comment on attachment 653511 [details] [diff] [review]
hairless robots, revised

>+      #errorPageContainer {
>+      	background-image: none;

Please replace the tab stop with two spaces.

Looks good otherwise. Thanks!
Attachment #653511 - Flags: review?(dao) → review+
Ah, I didn't even notice the whitespace issue.
Attachment #653511 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1f256d6070ac
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: