Last Comment Bug 739115 - Port wifi and netutils code to ICS interfaces
: Port wifi and netutils code to ICS interfaces
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: ---
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
Mentors:
: 737704 (view as bug list)
Depends on: 739335
Blocks: gonk-ics
  Show dependency treegraph
 
Reported: 2012-03-25 18:09 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2012-03-27 07:16 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add runtime checks for ICS and select libnetutils interface and wpa_supplicant states appropriately (12.64 KB, patch)
2012-03-25 18:48 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
gal: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-25 18:09:45 PDT
Helpfully, the libnetutils interface changed in ICS.  Also, the wpa_supplicant states changed in a non-backwards compatible way.  We need to handle these changes.

philikon, I see that the RIL code has its own import of netutils.  We'll need the netutils fixes there.  Or better, let's share a netutils.  Maybe your network manager patch does that.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-25 18:48:34 PDT
Created attachment 609186 [details] [diff] [review]
Add runtime checks for ICS and select libnetutils interface and wpa_supplicant states appropriately

There's some duplicated code in here, but I don't know how to share it without even worse hackery.

This stuff needs to be refactored along with RIL.
Comment 2 Andreas Gal :gal 2012-03-25 19:22:32 PDT
Comment on attachment 609186 [details] [diff] [review]
Add runtime checks for ICS and select libnetutils interface and wpa_supplicant states appropriately

Review of attachment 609186 [details] [diff] [review]:
-----------------------------------------------------------------

Land it. -15 karma for duplicating that code there. I am sure Blake will clean it up for you.
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-25 19:40:53 PDT
https://hg.mozilla.org/mozilla-central/rev/7f87b434f7c6
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-25 20:52:30 PDT
*** Bug 737704 has been marked as a duplicate of this bug. ***
Comment 5 Philipp von Weitershausen [:philikon] 2012-03-26 14:27:29 PDT
(In reply to Chris Jones [:cjones] [:warhammer] from comment #0)
> philikon, I see that the RIL code has its own import of netutils.  We'll
> need the netutils fixes there.  Or better, let's share a netutils.  Maybe
> your network manager patch does that.

Correct. See bug 738063 which I didn't get to land before I went away for a few days last week. I'll rebase.

Note You need to log in before you can comment on or make changes to this bug.