Last Comment Bug 739139 - Fix build of nsAppShell.cpp on gonk-gb
: Fix build of nsAppShell.cpp on gonk-gb
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: unspecified
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla14
Assigned To: Michael Wu [:mwu]
:
Mentors:
Depends on: 737199
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-25 23:42 PDT by Michael Wu [:mwu]
Modified: 2012-03-26 14:23 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix build of nsAppShell.cpp on gonk-ics (207.59 KB, patch)
2012-03-25 23:42 PDT, Michael Wu [:mwu]
no flags Details | Diff | Splinter Review
Fix build of nsAppShell.cpp on gonk-gb (278.08 KB, patch)
2012-03-26 14:18 PDT, Michael Wu [:mwu]
no flags Details | Diff | Splinter Review

Description Michael Wu [:mwu] 2012-03-25 23:42:16 PDT
Created attachment 609231 [details] [diff] [review]
Fix build of nsAppShell.cpp on gonk-ics

I haven't tested this on ICS.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-26 00:30:11 PDT
/home/cjones/mozilla/b2g/gecko/widget/gonk/libui/Timers.cpp:118:63: error: macro "ALOG" requires 3 arguments, but only 1 given
Tokenizer.cpp
/home/cjones/mozilla/b2g/gecko/widget/gonk/libui/Timers.cpp: In static member function 'static void android::DurationTimer::addToTimeval(timeval*, long int)':
/home/cjones/mozilla/b2g/gecko/widget/gonk/libui/Timers.cpp:118: error: 'ALOG' was not declared in this scope
Comment 2 Michael Wu [:mwu] 2012-03-26 14:18:35 PDT
Created attachment 609486 [details] [diff] [review]
Fix build of nsAppShell.cpp on gonk-gb
Comment 3 Michael Wu [:mwu] 2012-03-26 14:23:16 PDT
https://hg.mozilla.org/mozilla-central/rev/04d45f71df7a

Note You need to log in before you can comment on or make changes to this bug.