739153 - bugzilla pegs cpu at 100% if the db server returns "Unknown table engine 'InnoDB'"

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

bugzilla pegs cpu at 100% if the db server returns "Unknown table engine 'InnoDB'" (see bug 731665).

my guess is the arecibo customisations would be the cause for this.

Comment 1

[:glob ✱]

there's deep recursion, causing the httpd process to peg the cpu and never stop.  this kills the server.

we need to get this patched and deployed asap; if there's a db issue on production this bug will quickly kill the webheads.


i have a patch which works in my dev env, waiting for it to be deployed to stage-tip for testing.

Comment 2

[:glob ✱]

Attachment: patch v1

this patch does a few things:

- detects and blocks recursive calls to our die handler
- incorporates the fix from bug 734834 wrt ModPerl::Util::exit
- always outputs a content-type header, which was missing in some circumstances
- removes "at /path/to/file line 0." info from the error (but not from logs)g
- doesn't invoke arecibo when using command-line tools

Comment 3

[:glob ✱]

dkl, ping?

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 609298 [details] [diff] [review]
patch v1

Review of attachment 609298 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified Bugzilla/Arecibo.pm
modified Bugzilla/Error.pm
Committed revision 8126.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified Bugzilla/Arecibo.pm
modified Bugzilla/Error.pm
Committed revision 8113.