[UI] Invalid HTML for Bugzilla pop-ups

VERIFIED FIXED in 4

Status

Socorro
Webapp
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: espressive, Assigned: espressive)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
On tcbs the code for the bug_ids_expanded_list, also reused on individual crash pages, incorrectly nests an unordered list inside a definition list leading to additional validation errors for this page.
(Assignee)

Comment 1

6 years ago
Sent pull request :: https://github.com/mozilla/socorro/pull/461

TEST CASE
---------

Head over to top crashers by version and right click on a 'Bugzilla IDs' content cell. In Firebug or FF dev tools, expand the <td> and look for a div with the class bug_ids_expanded_list. Expand this div and inside, the ul with class bug_ids_expanded, should no longer be wrapped with a <dl> 

This can also be tested on individual crash reports that have related bugzilla bug links. No functionality should be affected by this change.

Comment 2

6 years ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/624992e029ef46ad60ec1f2f31cad64be35b7a28
Merge pull request #461 from ossreleasefeed/invalid-html-bugzilla-popup-739155

removed wrapping definition list fixes bug 739155
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Created attachment 611510 [details]
qa - verified

QA verified on stage -

Updated

6 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.