The default bug view has changed. See this FAQ.

Chat - The contact info header in the sidebar incorrectly gets a persona background.

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 14.0
All
Mac OS X
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Created attachment 609283 [details]
screenshot of the issue

The contact info header in the sidebar incorrectly gets a persona background on the mac.
(Assignee)

Comment 1

5 years ago
Created attachment 611134 [details] [diff] [review]
Patch

Set for contextPane a background color to avoid lightweight theme backgrounds.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #611134 - Flags: ui-review?(nisses.mail)
Attachment #611134 - Flags: review?(nisses.mail)
(Assignee)

Updated

5 years ago
Attachment #611134 - Attachment is patch: true
My intent was to have in this area the same background as the email headers have in the email tab.
Any reason why http://mxr.mozilla.org/comm-central/source/mail/components/im/themes/chat.css#117 doesn't produce this effect?
(Assignee)

Comment 3

5 years ago
The styles for the Persona (Lightweight themes) are overwriting this style. With a !important this would override the Persona styles. I can do this and add it to this patch. But because this change is in /mail/components/im/themes/chat.css do I need a review from you?
If just adding an !important to the existing rule is enough (and keeps the grandient that looks like a shadow) I think I would prefer that, but I'm ok with letting Andreas decide how things should look.

I think for the mail/components/im/ folder you can get reviews like for other parts of the Thunderbird UI, but I'm not completely sure of the review policy for that folder actually. As I'm the author of most of these files I'm likely to look and have an opinion even if I'm not the official reviewer. :)
(Assignee)

Comment 5

5 years ago
Created attachment 611142 [details] [diff] [review]
Patch v2

Make the toolbar shadow appear also with Persona applied.
Attachment #611134 - Attachment is obsolete: true
Attachment #611134 - Flags: ui-review?(nisses.mail)
Attachment #611134 - Flags: review?(nisses.mail)
Attachment #611142 - Flags: ui-review?(nisses.mail)
Attachment #611142 - Flags: review?(nisses.mail)
Attachment #611142 - Flags: review?(florian)
(Reporter)

Updated

5 years ago
Blocks: 714733
(Reporter)

Comment 6

5 years ago
I think the shadow works well in the single message case, because it looks like the toolbar casts a shadow across the whole area under it, but in this case it looks a bit weird that just the right pane gets a shadow.
(Reporter)

Updated

5 years ago
Attachment #611142 - Flags: ui-review?(nisses.mail) → ui-review-
(Reporter)

Comment 7

5 years ago
it would also be good with a line above "Previous conversations"
(Assignee)

Comment 8

5 years ago
Created attachment 611538 [details] [diff] [review]
Patch v3

I've removed the shadow completely and gave the bottom border a !important to show also with Personas enabled.
Attachment #611142 - Attachment is obsolete: true
Attachment #611142 - Flags: review?(nisses.mail)
Attachment #611142 - Flags: review?(florian)
Attachment #611538 - Flags: ui-review?(nisses.mail)
Attachment #611538 - Flags: review?(nisses.mail)
Attachment #611538 - Flags: review?(florian)
(Reporter)

Comment 9

5 years ago
Comment on attachment 611538 [details] [diff] [review]
Patch v3

I'm not super-happy about parts of this code living inside a %ifdef instead of the platform theme directory, but thats how it was before as well, so it will work for now.
I like to see css documentation though, so that makes me happy again :)
Visually, it's perfect!
Attachment #611538 - Flags: ui-review?(nisses.mail)
Attachment #611538 - Flags: ui-review+
Attachment #611538 - Flags: review?(nisses.mail)
Attachment #611538 - Flags: review+
Comment on attachment 611538 [details] [diff] [review]
Patch v3

I'm ok with letting Andreas decide how this should look and review this, so you don't really need my review here (I've looked quickly at the patch and see nothing wrong, but I haven't tested it, so not putting the r+ flag).
Attachment #611538 - Flags: review?(florian)
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/a767bf83251a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Assignee)

Comment 12

5 years ago
Comment on attachment 611538 [details] [diff] [review]
Patch v3

[Approval Request Comment]
User impact if declined: Inconsistent UI between versions from beginning
Attachment #611538 - Flags: approval-comm-aurora?
Attachment #611538 - Flags: approval-comm-aurora? → approval-comm-aurora+
http://hg.mozilla.org/releases/comm-aurora/rev/a82506eb7e8c
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.