Closed Bug 739181 Opened 9 years ago Closed 9 years ago

Chat - The contact info header in the sidebar incorrectly gets a persona background.

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

(thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed

People

(Reporter: andreasn, Assigned: Paenglab)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached image screenshot of the issue
The contact info header in the sidebar incorrectly gets a persona background on the mac.
Attached patch Patch (obsolete) — Splinter Review
Set for contextPane a background color to avoid lightweight theme backgrounds.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #611134 - Flags: ui-review?(nisses.mail)
Attachment #611134 - Flags: review?(nisses.mail)
Attachment #611134 - Attachment is patch: true
My intent was to have in this area the same background as the email headers have in the email tab.
Any reason why http://mxr.mozilla.org/comm-central/source/mail/components/im/themes/chat.css#117 doesn't produce this effect?
The styles for the Persona (Lightweight themes) are overwriting this style. With a !important this would override the Persona styles. I can do this and add it to this patch. But because this change is in /mail/components/im/themes/chat.css do I need a review from you?
If just adding an !important to the existing rule is enough (and keeps the grandient that looks like a shadow) I think I would prefer that, but I'm ok with letting Andreas decide how things should look.

I think for the mail/components/im/ folder you can get reviews like for other parts of the Thunderbird UI, but I'm not completely sure of the review policy for that folder actually. As I'm the author of most of these files I'm likely to look and have an opinion even if I'm not the official reviewer. :)
Attached patch Patch v2 (obsolete) — Splinter Review
Make the toolbar shadow appear also with Persona applied.
Attachment #611134 - Attachment is obsolete: true
Attachment #611134 - Flags: ui-review?(nisses.mail)
Attachment #611134 - Flags: review?(nisses.mail)
Attachment #611142 - Flags: ui-review?(nisses.mail)
Attachment #611142 - Flags: review?(nisses.mail)
Attachment #611142 - Flags: review?(florian)
Blocks: 714733
I think the shadow works well in the single message case, because it looks like the toolbar casts a shadow across the whole area under it, but in this case it looks a bit weird that just the right pane gets a shadow.
Attachment #611142 - Flags: ui-review?(nisses.mail) → ui-review-
it would also be good with a line above "Previous conversations"
Attached patch Patch v3Splinter Review
I've removed the shadow completely and gave the bottom border a !important to show also with Personas enabled.
Attachment #611142 - Attachment is obsolete: true
Attachment #611142 - Flags: review?(nisses.mail)
Attachment #611142 - Flags: review?(florian)
Attachment #611538 - Flags: ui-review?(nisses.mail)
Attachment #611538 - Flags: review?(nisses.mail)
Attachment #611538 - Flags: review?(florian)
Comment on attachment 611538 [details] [diff] [review]
Patch v3

I'm not super-happy about parts of this code living inside a %ifdef instead of the platform theme directory, but thats how it was before as well, so it will work for now.
I like to see css documentation though, so that makes me happy again :)
Visually, it's perfect!
Attachment #611538 - Flags: ui-review?(nisses.mail)
Attachment #611538 - Flags: ui-review+
Attachment #611538 - Flags: review?(nisses.mail)
Attachment #611538 - Flags: review+
Comment on attachment 611538 [details] [diff] [review]
Patch v3

I'm ok with letting Andreas decide how this should look and review this, so you don't really need my review here (I've looked quickly at the patch and see nothing wrong, but I haven't tested it, so not putting the r+ flag).
Attachment #611538 - Flags: review?(florian)
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/a767bf83251a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 611538 [details] [diff] [review]
Patch v3

[Approval Request Comment]
User impact if declined: Inconsistent UI between versions from beginning
Attachment #611538 - Flags: approval-comm-aurora?
Attachment #611538 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.