Closed Bug 739215 Opened 8 years ago Closed 8 years ago

Favicon for about:firefox

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 14

People

(Reporter: aaronmt, Assigned: wesj)

References

Details

(Keywords: uiwanted, Whiteboard: polish)

Attachments

(3 files)

First-run visit to Top Sites now lists (4) default bookmarks -- they each have a representative Favicon except for about:firefox. Eliminate this silliness.
This should be fixed for real when bug 709250 is fixed.
Depends on: 709250
I initially implemented support for a "default" about favicon in bug 709250, but removed it. There's some options here. Ship a default in Java, or extend the default bookmarks code to support a path to the favicon.

I intend to do the later, but needed bug 709250 to land first. It is now!
Just adding a comment here for comment #1, that this didn't resolve with 709259 (tested Nightly 03/28).
(bug 709250)
That's because the XHTML does not include a favicon:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/about.xhtml#56

Copy the favicon <link> from aboutHome.xhtml or aboutAddons.xhtml
Assignee: nobody → wjohnston
Attachment #610251 - Flags: review?(mark.finkle)
This updates about:firefox to have A favicon, but also updates a bunch of our other about pages to offer high res favicons.
Attachment #610252 - Flags: review?(mark.finkle)
Attached patch Simple patchSplinter Review
This just adds favicons to our android resources for about:firefox. Favicon is just a copy of favicon32.png. The default bookmarks code will pick it up and use it. Had to do it 5 times for each branding set we have.

This isn't needed for about:home because. Since we load it as our first page, we also load the favicon from the jar file soon after first start (although there is probably a short time where we won't have anything to show).
Attachment #610767 - Flags: review?(mark.finkle)
Comment on attachment 610251 [details] [diff] [review]
Patch 1/2 - Add support for a path to a favicon

Removing review. Will move this to another bug.
Attachment #610251 - Flags: review?(mark.finkle)
Comment on attachment 610252 [details] [diff] [review]
Patch 2/2 - Use high res favicons

Will move to another bug.
Attachment #610252 - Flags: review?(mark.finkle)
Comment on attachment 610767 [details] [diff] [review]
Simple patch

It took me a while to find it in my heart to feel OK about this patch. But I feel OK about it now.
Attachment #610767 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/7c63bedbb9b2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Verified/fixed on:
Nightly Fennec 14.0a1 (2012-04-12)
Device: HTC Desire Z
OS: Android 2.3.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.