Last Comment Bug 739222 - Noise in the terminal at startup if no default account
: Noise in the terminal at startup if no default account
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 14.0
Assigned To: Florian Quèze [:florian] [:flo]
:
:
Mentors:
Depends on: null_default_server
Blocks: tb-noise
  Show dependency treegraph
 
Reported: 2012-03-26 07:38 PDT by Florian Quèze [:florian] [:flo]
Modified: 2012-04-13 03:22 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (1.73 KB, patch)
2012-03-26 07:38 PDT, Florian Quèze [:florian] [:flo]
mozilla: review+
Details | Diff | Splinter Review

Description Florian Quèze [:florian] [:flo] 2012-03-26 07:38:17 PDT
Created attachment 609317 [details] [diff] [review]
Patch

accountManager.defaultAccount throws if there's no default account. There was some effort in bug 342632 to change that, but it got stalled.

I think just getting rid of the noise in the terminal would already be an improvement. This is what the patch I'm attaching does (it doesn't hide the error when it's unexpected; it will go to the console instead of the terminal).
Comment 1 Mark Banner (:standard8) 2012-03-27 02:33:18 PDT
Comment on attachment 609317 [details] [diff] [review]
Patch

Whilst I think this is fine, David knows a bit more about the accounts system than I do.
Comment 2 :aceman 2012-03-27 05:07:42 PDT
Can't we set some account to be the default automatically?
Or is this in the case there really doesn't exist any account?
Comment 3 :aceman 2012-03-27 05:08:55 PDT
Sorry again, seems that is what http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgAccountManager.cpp#772 is doing :)
Comment 4 Florian Quèze [:florian] [:flo] 2012-04-13 03:22:47 PDT
http://hg.mozilla.org/comm-central/rev/2f4ac17756fd

Note You need to log in before you can comment on or make changes to this bug.