Last Comment Bug 739248 - fix "comparison between signed and unsigned integer expressions" warnings in mozHunspell.cpp and mozSpellChecker.cpp
: fix "comparison between signed and unsigned integer expressions" warnings in ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Spelling checker (show other bugs)
: unspecified
: All Linux
: -- normal (vote)
: mozilla14
Assigned To: Nathan Froyd [:froydnj]
:
: Jet Villegas (:jet)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-26 08:38 PDT by Nathan Froyd [:froydnj]
Modified: 2012-03-27 05:32 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.79 KB, patch)
2012-03-26 08:41 PDT, Nathan Froyd [:froydnj]
ehsan: review+
Details | Diff | Splinter Review

Description Nathan Froyd [:froydnj] 2012-03-26 08:38:47 PDT
/home/froydnj/src/m-c.git/extensions/spellcheck/src/mozSpellChecker.cpp: In member function 'virtual nsresult mozSpellChecker::GetDictionaryList(nsTArray<nsString>*)':
/home/froydnj/src/m-c.git/extensions/spellcheck/src/mozSpellChecker.cpp:321:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/home/froydnj/src/m-c.git/extensions/spellcheck/src/mozSpellChecker.cpp: In member function 'virtual nsresult mozSpellChecker::SetCurrentDictionary(const nsAString_internal&)':
/home/froydnj/src/m-c.git/extensions/spellcheck/src/mozSpellChecker.cpp:379:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/home/froydnj/src/m-c.git/extensions/spellcheck/hunspell/src/mozHunspell.cpp: In member function 'void mozHunspell::LoadDictionaryList()':
/home/froydnj/src/m-c.git/extensions/spellcheck/hunspell/src/mozHunspell.cpp:423:54: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Comment 1 Nathan Froyd [:froydnj] 2012-03-26 08:41:31 PDT
Created attachment 609335 [details] [diff] [review]
patch

I'm not sure who's supposed to be reviewing this given there's no listed module owner.  Ehsan, you look like a likely candidate.
Comment 3 Marco Bonardo [::mak] 2012-03-27 05:32:39 PDT
https://hg.mozilla.org/mozilla-central/rev/6363e4983d50

Note You need to log in before you can comment on or make changes to this bug.