The default bug view has changed. See this FAQ.

fix "comparison between signed and unsigned integer expressions" warnings in mozHunspell.cpp and mozSpellChecker.cpp

RESOLVED FIXED in mozilla14

Status

()

Core
Spelling checker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla14
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
/home/froydnj/src/m-c.git/extensions/spellcheck/src/mozSpellChecker.cpp: In member function 'virtual nsresult mozSpellChecker::GetDictionaryList(nsTArray<nsString>*)':
/home/froydnj/src/m-c.git/extensions/spellcheck/src/mozSpellChecker.cpp:321:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/home/froydnj/src/m-c.git/extensions/spellcheck/src/mozSpellChecker.cpp: In member function 'virtual nsresult mozSpellChecker::SetCurrentDictionary(const nsAString_internal&)':
/home/froydnj/src/m-c.git/extensions/spellcheck/src/mozSpellChecker.cpp:379:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/home/froydnj/src/m-c.git/extensions/spellcheck/hunspell/src/mozHunspell.cpp: In member function 'void mozHunspell::LoadDictionaryList()':
/home/froydnj/src/m-c.git/extensions/spellcheck/hunspell/src/mozHunspell.cpp:423:54: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
(Assignee)

Comment 1

5 years ago
Created attachment 609335 [details] [diff] [review]
patch

I'm not sure who's supposed to be reviewing this given there's no listed module owner.  Ehsan, you look like a likely candidate.
Attachment #609335 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #609335 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6363e4983d50
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/6363e4983d50
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.