fix nsBrowserApp.cpp "comparison between signed and unsigned integer expressions" warning

RESOLVED FIXED in Firefox 14

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
Firefox 14
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
/home/froydnj/src/m-c.git/browser/app/nsBrowserApp.cpp: In function 'int main(int, char**)':
/home/froydnj/src/m-c.git/browser/app/nsBrowserApp.cpp:208:77: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
(Assignee)

Comment 1

5 years ago
Created attachment 609338 [details] [diff] [review]
patch
Attachment #609338 - Flags: review?(ehsan)
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p all -u all -t none]

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p all -u all -t none] → [autoland-in-queue]

Comment 2

5 years ago
Autoland Patchset:
	Patches: 609338
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=5e5d6536d473
Try run started, revision 5e5d6536d473. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=5e5d6536d473
Attachment #609338 - Flags: review?(ehsan) → review+
(Assignee)

Comment 3

5 years ago
Try run looks good, pushing:

https://hg.mozilla.org/integration/mozilla-inbound/rev/940563684bef
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 14

Comment 4

5 years ago
Try run for 5e5d6536d473 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=5e5d6536d473
Results (out of 222 total builds):
    success: 191
    warnings: 24
    failure: 7
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-5e5d6536d473

Updated

5 years ago
Whiteboard: [autoland-in-queue]
https://hg.mozilla.org/mozilla-central/rev/940563684bef
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.