739270 - Unable to upload a valid add-on in fresh vagrant install of AMO

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Wraithan (Chris McDonald) [:wraithan]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20100101 Firefox/12.0
Build ID: 20120321033733

Steps to reproduce:

I setup a fresh install of zamboni using the vagrant method. After resolving issues for login (bug #739268) then a bug with redis failing (bug #736673) I tried to upload an add-on I've been able to successfully upload on the live site.


Actual results:

The addon is rejected stating that my version number is invalid.


Expected results:

My add-on should have been accepted. I resolved this by symlinking /home/vagrant/project/vendor/src/amo-validator/validator/app_versions.json to /home/vagrant/project/tmp/apps.json because AMO is reading tmp/apps.json rather than the app_versions.json

I don't know if there is a better way to handle this. If there isn't, then the setup scripts should symlink that automatically, or, at the very least, the instructions should say to symlink that file.

Comment 1

[Kumar McMillan [:kumar]]

actually, the validator should be reading apps.json but in this case the dev db doesn't have the newer versions. The way I handle this is just edit the addon xpi and set the max version to something lower. You could alternatively add new versions to your dev server on this page http://localhost:8000/en-US/admin/models/applications/application/1/

You need to create yourself a super user first before doing that. This is documented here http://mozilla.github.com/zamboni/topics/install-zamboni/installation.html#create-an-admin-user

Comment 2

[Wraithan (Chris McDonald) [:wraithan]]

Editing the XPI is a pain if you are using jetpack as it requires unpacking and repacking manually. Also I vaguely remember running into an issue doing that because the FX4_MIN version didn't exist or something like that. I could go back and test that but I think there is potentially a better fix.

I can see why adding via a form is handy in production (since a release of AMO won't always coincide with the release of a new Firefox version) but the validator has all the valid versions and it (appears) to work great in dev just symlinking the file.

Comment 3

[Kumar McMillan [:kumar]]

You can use:

./scripts/xpitool.py --extract path/to/addons.xpi
[make edits]
./scripts/xpitool.py --recreate path/to/addons/

This is available in the zamboni repo.

A good fix would be to add some mysql insert statements to the vagrant provisioning scripts or to fix the way our landfill DB gets created. cc'ing wil for that last one.

Comment 4

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/