739294 - Zombie compartment with ABP and jailbaitgallery.com

Status: RESOLVED INCOMPLETE

(Core :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

STR:

 * Open http://jailbaitgallery.com/search.php?q=Kairi+&search=Search (NSFW, and unpleasant to boot.  I think this bug doesn't have anything to do with images, so you should be able to disable them.)

 * Command-click a few thumbnails to open them.  Each page which loads will hang the browser and show an unresponsive-script dialog.  Click "stop script".

 * Close all the tabs.

Results: Zombie compartment.

This is a particularly bad zombie because the page creates millions of objects (dom nodes?  not sure yet).  The CC falls over once these objects are detached from the page.

But more generally, I've been seeing an occasional zombie I think might be related to ABP, and perhaps this page is a good testcase.

Comment 1

[Wladimir Palant]

So far I reproduced the script hang and extremely slow CC but not the zombie compartment. Which Firefox version were you using?

Comment 2

[Justin Lebar (not reading bugmail)]

14.0a1 (2012-03-26), ABP 2.0.4a3417.  I see that I'm about to get an ABP update.

Comment 3

[Andrew McCreight [:mccr8]]

The bulk of the graph is these kinds of nodes:
 4180084 nsGenericDOMDataNode
 2924563 nsGenericElement (xhtml)
 1255920 nsChildContentList

After that it falls to 22k JS objects, followed by misc. other stuff.

They have stuff that looks like:
0x1230480c0 [rc=1] nsGenericElement (xhtml) input class='newtab-control newtab-control-pin' about:newtab
0x112771920 [rc=5] nsGenericElement (xhtml) a class='newtab-link' about:newtab

Comment 4

[Justin Lebar (not reading bugmail)]

FWIW, feproducing the zombie was somewhat fiddly -- it happened only about half the time.

Comment 5

[Justin Lebar (not reading bugmail)]

(In reply to Justin Lebar [:jlebar] from comment #4)
> FWIW, feproducing the zombie was somewhat fiddly -- it happened only about
> half the time.

It could have to do with the particular ad that's shown on the pages.

Comment 6

[Andrew McCreight [:mccr8]]

These are mostly span nodes.

4180084 nsGenericDOMDataNode
2924056 nsGenericElement (xhtml) span 
1255920 nsChildContentList
  22968 JS Object
   1075 nsXPCWrappedJS

About 826k of these nodes are like this:
nsGenericElement (xhtml) span class='searchword' http://webpage.com/index.php?id=16778

Comment 7

[Justin Lebar (not reading bugmail)]

I can't seem to reproduce with ABP 2.0.4a3420.  I do still see high heap-unclassified after closing the tab, but that's a separate issue not likely related to ABP.

Comment 8

[Wladimir Palant]

The changes between ABP 2.0.4a3417 and 2.0.4a3420 are definitely unrelated - it isn't code that runs when web pages load. So the update couldn't have fixed the issue.

Comment 9

[Wladimir Palant]

Sorry, I absolutely cannot reproduce it on my side. I am testing with Windows 7 because I don't have OS X but that shouldn't matter if the leak were due to ABP. The hang is easy to explain - the highlighting script is meant to highlight search keywords but due to a bug it attempts to highlight the empty string. Unfortunately that doesn't explain why something would leak here.

Comment 10

[Justin Lebar (not reading bugmail)]

I guess we should forget about it.  I'm having difficulty reproducing now too.  I'd care a lot more if it were happening on a less-despicable site.

I'm sorry to have sent you on a wild goose chase, Waldimir.