navigator.mozApps - app uninstall

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Apps
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: onecyrenus, Assigned: ianb)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 609405 [details]
patch for webapps.js

Currently if you call uninstall on an app that is no longer installed, the onerror handler is invoked as expected but the error message is the origin ? 

this is something that would be hard to script around, my recommendation would be to return a string indicating that the app was not able to be uninstalled.
(Reporter)

Comment 1

5 years ago
Currently the HTML / JS implementation returns NOT_INSTALLED... which is interesting because that was the reason we were calling uninstall.. 

maybe something like UNABLE_TO_FIND_APP would be more useful
(Assignee)

Comment 2

5 years ago
NOT_INSTALLED is the error message Fabrice and I discussed on IRC.
Yes, NOT_INSTALLED makes more sense. You just can't uninstall something that's not installed ;)
OS: Mac OS X → All
Hardware: x86 → All
(Reporter)

Updated

5 years ago
Whiteboard: [mozApps API 1.0]

Updated

5 years ago
Component: DOM → DOM: Mozilla Extensions

Updated

5 years ago
Blocks: 746465

Updated

5 years ago
Whiteboard: [mozApps API 1.0]
(Assignee)

Comment 4

5 years ago
Created attachment 632109 [details] [diff] [review]
Fix for bug, test, and fix for test

This just ignores the message data sent from Webapps.jsm to Webapps.js (and turns all uninstall errors to NOT_INSTALLED), which seems to happen elsewhere in the codebase, but seems a little fishy.  Maybe it should send the error name as the data.
Assignee: nobody → ianb
Attachment #609405 - Attachment is obsolete: true
Attachment #632109 - Flags: review?(fabrice)
Attachment #632109 - Flags: review?(fabrice) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Comment on attachment 632109 [details] [diff] [review]
Fix for bug, test, and fix for test

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fb04d9a0ace
Attachment #632109 - Flags: checkin+
Keywords: checkin-needed
Target Milestone: --- → mozilla16

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5fb04d9a0ace
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Component: DOM: Mozilla Extensions → DOM: Apps
You need to log in before you can comment on or make changes to this bug.