739393 - New tab opened in background is not set to inactive

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce:
1. Long-press on a link
2. Choose "open in new tab"

Expected results: The new tab opens in the background and its docshell is inactive (e.g. JavaScript timers are throttled).

Actual results: The new tab opens in the background and its docshell is active (timers are unthrottled).

The fix is simple but we should probably also have tests for this.

Comment 1

[Matt Brubeck (:mbrubeck)]

Comment on attachment 609471 [details] [diff] [review]
patch

This patch does not work correctly.  Setting browser.docShell.isActive too soon after the browser is created has no effect, and also seems to prevent later assignements from having any effect.  It also seems to cause an intermittent exception during startup that leaves the browser in a broken state.

We might need to call setActive after a timeout, or something.

Comment 2

[Matt Brubeck (:mbrubeck)]

Desktop Firefox sets docShellIsActive=false on all newly-created <browser> elements without a timeout... I haven't figured out yet why this isn't working in Fennec.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

I found out that docShellIsActive will only work after the <browser> element has been added to the DOM.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 616419 [details] [diff] [review]
patch v2

In hindsight it makes perfect sense. Nice catch.

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/7a227bcb5bde

Comment 6

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 21.0a1 (2013-02-11)
-device: Samsung Galaxy Nexus 
-OS: Android 4.1.2