Implement ARB_sync in GLContext

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

(Blocks: 1 bug)

unspecified
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

6 years ago
There are a couple different bugs around which need ARB_sync. We should throw it into GLContext here, since it's easy to simply implement and expose it. At least we can get ARB_sync into GLContext quickly, and get the individual uses in as they become ready.
(Assignee)

Comment 1

6 years ago
Created attachment 609525 [details] [diff] [review]
Implement/expose ARB_sync to GLContext
Attachment #609525 - Flags: review?(bjacob)
(Assignee)

Comment 2

6 years ago
This patch exposes FenceSync, DeleteSync, WaitSync, and GetSynciv as per spec. Other functions are part of the spec as well, but these are the functions that are most useful to us, and that I have seen used by other patches.
Attachment #609525 - Flags: review?(bjacob) → review+
(Assignee)

Comment 3

6 years ago
Waiting on Try build:
https://tbpl.mozilla.org/?tree=Try&rev=9194ec4fb9f4
Whiteboard: [rplus]
(Assignee)

Comment 4

6 years ago
Created attachment 611088 [details] [diff] [review]
Implement/expose ARB_sync to GLContext

Same patch in principle, but exposes all functionality of ARB_sync, instead of what I had arbitrarily (and incorrectly) thought would be all we would need.

Try-build at:
https://tbpl.mozilla.org/?tree=Try&rev=526c6332ba2a
Attachment #609525 - Attachment is obsolete: true
Attachment #611088 - Flags: review?(bjacob)
(Assignee)

Updated

6 years ago
Whiteboard: [rplus]
(Assignee)

Comment 5

6 years ago
Created attachment 611094 [details] [diff] [review]
Implement/expose ARB_sync to GLContext
Attachment #611088 - Attachment is obsolete: true
Attachment #611088 - Flags: review?(bjacob)
Attachment #611094 - Flags: review?(bjacob)
(Assignee)

Comment 6

6 years ago
Try-build:
https://tbpl.mozilla.org/?tree=Try&rev=2d41ddc2e40a
(Assignee)

Comment 7

6 years ago
Created attachment 612703 [details] [diff] [review]
Implement/expose ARB_sync to GLContext

Finally got it building on android by using "mozilla/StandardInteger.h".
Attachment #611094 - Attachment is obsolete: true
Attachment #611094 - Flags: review?(bjacob)
Attachment #612703 - Flags: review?(bjacob)
(Assignee)

Comment 8

6 years ago
Created attachment 612737 [details] [diff] [review]
Implement/expose ARB_sync to GLContext

Bitrot from bug 741689.
Attachment #612703 - Attachment is obsolete: true
Attachment #612703 - Flags: review?(bjacob)
Attachment #612737 - Flags: review?(bjacob)
Attachment #612737 - Flags: review?(bjacob) → review+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a29bc0e8de0a
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/a29bc0e8de0a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 555834
You need to log in before you can comment on or make changes to this bug.