73956 - Form Manager not saving input information

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Tracy Walker [:tracy]]

seen on mac commercial build 2001-03-29-04-trunk

-goto Tasks | Privacy & Security | Form Manager | View Stored Data
-Enter some info in the fields (first, last name)
-click okay
-return to View Stored Data

the information previously entered is not there.  attempts to use the form 
manager to prefill a form fail because there is never anything in the form 
manager to insert into the form.

Comment 1

[Stephen P. Morse]

Very strange since I didn't change anything in the form manager since 
yesterday's good build.  Investigating.

Comment 2

[Simon Fraser [no longer active]]

Is this really Mac-only?

Comment 3

[Stephen P. Morse]

Simon, I asked the same question and am waiting for an answer from tracy walker.  
In the meantime I am currently building today's tree on both win32 and linux in 
the event that this is cross platform.

Comment 4

[Tracy Walker [:tracy]]

yes, this is Mac only.

Comment 5

[Paul Chen]

Just built a commercial mac build, there's a JS error:

chrome://communicator/content/wallet/WalletViewer.js line 56: 
Components.classes['@mozilla.org/walleteditor/walleteditor-world;1'] has no 
properties

Looks like we're missing something here ;-)

Comment 6

[Stephen P. Morse]

That's interesting.  My win32 build should finish soon and I want to see if we 
get that javascript error on win32.

Comment 7

[Paul Chen]

So I just looked at wallet.mcp, no one added nsWalletViewerFactory.cpp, which is 
where walletpreview, signonviewer, and walleteditor are registered. Or did 
someone put it somewhere else?

Comment 8

[Stephen P. Morse]

BTW, that component is supposed to get registered in 
extensions/wallet/build/nsWalletViewerFactory.cpp

Comment 9

[Stephen P. Morse]

Huh!  This is an old file so if was not in the project file how could this ever 
have worked on a mac.

Comment 10

[Paul Chen]

Ok, ok, I think I got it, mozilla/extensions/wallet/macbuild/walletviewers.mcp 
isn't in the mac build list.

Comment 11

[Stephen P. Morse]

Ah, it accidentally got deleted last night when the cookie stuff was added to 
MozillaBuildList.pm.  That explains it.

Comment 12

[Stephen P. Morse]

*** Bug 73955 has been marked as a duplicate of this bug. ***

Comment 13

[Stephen P. Morse]

Attachment: patch to restore walletviewer.mcp to build list

Comment 14

[Paul Chen]

yup, this is what I did locally to fix things, r=pchen

Comment 15

[Stephen P. Morse]

Fix checked in.

Comment 16

[Tracy Walker [:tracy]]

verified with commercial builds from 03/30