73959 - My Votes doesn't show up on buglist.cgi or attachment.cgi

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P2)

Description

[Jacob Steenhagen]

The link to My Votes in the page footer does not show up on the buglist.cgi
page. This is caused by the fact that:
if (!defined $::anyvotesallowed) {
    GetVersionTable();
}

Occurs *after*:
if ($::anyvotesallowed) {
    $html .= " | <A HREF=\"showvotes.cgi\">My votes</A>";
}

in CGI.pl's GetCommandMenu().

Patch forthcoming.

Comment 1

[Jacob Steenhagen]

Attachment: Move GetVersionTable() call

Comment 2

[Jacob Steenhagen]

Needs review and checkin.

Comment 3

[Dave Miller [:justdave]]

This WORKSFORME on the tip and on b.m.o.  I think the real reason for this may
have been the "not logged in footer" thing, which was fixed not too long ago...

Comment 4

[xyzzy]

Reopening.  I'm still getting this on b.m.o while logged in.  If it's fixed, I'm
not seeing it...

Comment 5

[Jacob Steenhagen]

I see this link come and go.  I think what happens is that sometime
GetVersionTable() is called before PutFooter() and sometimes it isn't (why, I
don't know... I haven't looked at the buglist.cgi code that closely).  If
GetVersionTable() is called prior to calling PutFooter(), then
$::anyvotesallowed will be set and it won't matter.

Comment 6

[Matthew Tuck [:CodeMachine]]

One thing that would happen periodically is that the versioncache gets rebuilt
automatically on a schedule, so GetVersionTable would call GenerateVersionTable
if it was past a certain age.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 29144 [details] [diff] [review]
Move GetVersionTable() call

Looks good, works.  r=myk, second review not needed.  checked in.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Patch is checked in, so resolving fixed.

Comment 9

[xyzzy]

Reopening again.  Just tested this, and not seeing it.  Are people testing this 
on show_bug.cgi and not buglist.cgi, perhaps?

Comment 10

[[e-mail]]

I also don't see it on the attachment edit email confirmation page.

Comment 11

[xyzzy]

Agreed, attachment.cgi not showing My Votes.  Not sure I know what "email 
confirmation" means...

Updating Summary.

Comment 12

[Jacob Steenhagen]

This fix has been checked in, but b.m.o hasn't updated yet.
Marking FIXED again