If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

My Votes doesn't show up on buglist.cgi or attachment.cgi

RESOLVED FIXED in Bugzilla 2.16

Status

()

Bugzilla
User Interface
P2
normal
RESOLVED FIXED
17 years ago
5 years ago

People

(Reporter: Jacob Steenhagen, Assigned: Jacob Steenhagen)

Tracking

2.11
Bugzilla 2.16

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
The link to My Votes in the page footer does not show up on the buglist.cgi
page. This is caused by the fact that:
if (!defined $::anyvotesallowed) {
    GetVersionTable();
}

Occurs *after*:
if ($::anyvotesallowed) {
    $html .= " | <A HREF=\"showvotes.cgi\">My votes</A>";
}

in CGI.pl's GetCommandMenu().

Patch forthcoming.
(Assignee)

Comment 1

17 years ago
Created attachment 29144 [details] [diff] [review]
Move GetVersionTable() call
(Assignee)

Comment 2

17 years ago
Needs review and checkin.
Assignee: tara → jake
Keywords: patch
Target Milestone: --- → Bugzilla 2.16
Priority: -- → P2
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

16 years ago
Component: Bugzilla → User Interface
Product: Webtools → Bugzilla
Version: Bugzilla 2.11 → 2.11
This WORKSFORME on the tip and on b.m.o.  I think the real reason for this may
have been the "not logged in footer" thing, which was fixed not too long ago...
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → WORKSFORME

Comment 4

16 years ago
Reopening.  I'm still getting this on b.m.o while logged in.  If it's fixed, I'm
not seeing it...
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(Assignee)

Comment 5

16 years ago
I see this link come and go.  I think what happens is that sometime
GetVersionTable() is called before PutFooter() and sometimes it isn't (why, I
don't know... I haven't looked at the buglist.cgi code that closely).  If
GetVersionTable() is called prior to calling PutFooter(), then
$::anyvotesallowed will be set and it won't matter.
One thing that would happen periodically is that the versioncache gets rebuilt
automatically on a schedule, so GetVersionTable would call GenerateVersionTable
if it was past a certain age.
Comment on attachment 29144 [details] [diff] [review]
Move GetVersionTable() call

Looks good, works.  r=myk, second review not needed.  checked in.
Attachment #29144 - Flags: review+
Patch is checked in, so resolving fixed.
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED

Comment 9

16 years ago
Reopening again.  Just tested this, and not seeing it.  Are people testing this 
on show_bug.cgi and not buglist.cgi, perhaps?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 10

16 years ago
I also don't see it on the attachment edit email confirmation page.

Comment 11

16 years ago
Agreed, attachment.cgi not showing My Votes.  Not sure I know what "email 
confirmation" means...

Updating Summary.
Summary: My Votes doesn't show up on buglist.cgi → My Votes doesn't show up on buglist.cgi or attachment.cgi
(Assignee)

Comment 12

16 years ago
This fix has been checked in, but b.m.o hasn't updated yet.
Marking FIXED again
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.