Closed
Bug 739631
Opened 12 years ago
Closed 12 years ago
Filelink account management pane in preferences dialog needs styling polish for Windows XP
Categories
(Thunderbird :: Preferences, defect)
Tracking
(thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
Tracking | Status | |
---|---|---|
thunderbird13 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(4 files, 1 obsolete file)
34.97 KB,
image/png
|
Details | |
31.46 KB,
image/png
|
Details | |
71.88 KB,
image/png
|
Details | |
1.88 KB,
patch
|
mconley
:
review+
Bienvenu
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
On Windows XP, the Filelink account management pane looks a bit funny. In particular: 1) It looks like the Add / Remove buttons are being cut off at the bottom 2) The Dropbox / YouSendIt panels have scrollbars See screenshot.
Assignee | ||
Comment 1•12 years ago
|
||
Andreas: For problem (1) (Add / Remove buttons being cut off at the bottom), it looks like the cloudFileAuthErrorPanel is oversized, causing the tabpanels to be too large for the preferences dialog. Upon further investigation, it looks like the "key" graphic in that dialog might be a bit too large for Windows XP. Can we use a smaller version for XP? -Mike
Assignee | ||
Comment 2•12 years ago
|
||
Screenshots coming next.
Assignee: nobody → mconley
Attachment #611536 -
Flags: review?(nisses.mail)
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #611536 -
Flags: ui-review?(bwinton)
Assignee | ||
Comment 5•12 years ago
|
||
Andreas: Sorry, I forgot to mark it down - this patch relies on the patch in bug 739279 to be applied. -Mike
Comment 6•12 years ago
|
||
Comment on attachment 611536 [details] [diff] [review] The fix Yep, looks better. :) Thanks, Blake.
Attachment #611536 -
Flags: ui-review?(bwinton) → ui-review+
Comment 7•12 years ago
|
||
Comment on attachment 611536 [details] [diff] [review] The fix I got some scrollbars when trying to use the classic theme on Windows 7. Therefore I think we need to insert a media selector in preferences-aero.css specifically for Windows7 default theme. It should look something like this: @media all and (-moz-windows-default-theme) { #provider-management { here-goes-some-stuff-relevant-only-for-aero-basic-and-glass } } and then below that the patches current #provider-management class. The current #provider-management in preferences.css should be good as they are, as it's values will be overwritten by the ones in preferences-aero.css only under Windows Vista and 7.
Attachment #611536 -
Flags: review?(nisses.mail) → review-
Comment 8•12 years ago
|
||
(In reply to Andreas Nilsson (:andreasn) from comment #7) > and then below that the patches current #provider-management class. Meant id here of course.
Comment 9•12 years ago
|
||
This should take care of the classic-under-win7-issue
Assignee | ||
Updated•12 years ago
|
Attachment #611536 -
Attachment is obsolete: true
Assignee | ||
Comment 10•12 years ago
|
||
Comment on attachment 615332 [details] [diff] [review] the fix (v2) - ui-r+ from bwinton. Andreas: Works perfectly! Assigning myself for code review... -Mike
Attachment #615332 -
Attachment description: the fix (v2) → the fix (v2) - ui-r+ from bwinton.
Attachment #615332 -
Flags: review?(mconley)
Assignee | ||
Comment 11•12 years ago
|
||
Comment on attachment 615332 [details] [diff] [review] the fix (v2) - ui-r+ from bwinton. Review of attachment 615332 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thanks Andreas!
Attachment #615332 -
Flags: review?(mconley) → review+
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•12 years ago
|
Attachment #615332 -
Flags: approval-comm-aurora?
Updated•12 years ago
|
Attachment #615332 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 12•12 years ago
|
||
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/8f88b8cb546d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 13•12 years ago
|
||
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/2698b91bc7f4
status-thunderbird13:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•