Filelink account management pane in preferences dialog needs styling polish for Windows XP

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Preferences
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

Trunk
Thunderbird 14.0
x86
Windows XP
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Created attachment 609733 [details]
Screenshot of problem

On Windows XP, the Filelink account management pane looks a bit funny.  In particular:

1)  It looks like the Add / Remove buttons are being cut off at the bottom
2)  The Dropbox / YouSendIt panels have scrollbars

See screenshot.
Blocks: 698925
Andreas:

For problem (1) (Add / Remove buttons being cut off at the bottom), it looks like the cloudFileAuthErrorPanel is oversized, causing the tabpanels to be too large for the preferences dialog.

Upon further investigation, it looks like the "key" graphic in that dialog might be a bit too large for Windows XP.  Can we use a smaller version for XP?

-Mike
Created attachment 611536 [details] [diff] [review]
The fix

Screenshots coming next.
Assignee: nobody → mconley
Attachment #611536 - Flags: review?(nisses.mail)
Created attachment 611553 [details]
The fix in action on Win XP
Created attachment 611554 [details]
The fix in action on Win 7
Attachment #611536 - Flags: ui-review?(bwinton)
Depends on: 739279
Andreas:

Sorry, I forgot to mark it down - this patch relies on the patch in bug 739279 to be applied.

-Mike
Comment on attachment 611536 [details] [diff] [review]
The fix

Yep, looks better.  :)

Thanks,
Blake.
Attachment #611536 - Flags: ui-review?(bwinton) → ui-review+
Comment on attachment 611536 [details] [diff] [review]
The fix

I got some scrollbars when trying to use the classic theme on Windows 7.
Therefore I think we need to insert a media selector in preferences-aero.css specifically for Windows7 default theme. It should look something like this:

@media all and (-moz-windows-default-theme) {
  #provider-management {
  here-goes-some-stuff-relevant-only-for-aero-basic-and-glass
  }
}

and then below that the patches current #provider-management class. The current #provider-management in preferences.css should be good as they are, as it's values will be overwritten by the ones in preferences-aero.css only under Windows Vista and 7.
Attachment #611536 - Flags: review?(nisses.mail) → review-
(In reply to Andreas Nilsson (:andreasn) from comment #7)

> and then below that the patches current #provider-management class.
Meant id here of course.
Created attachment 615332 [details] [diff] [review]
the fix (v2) - ui-r+ from bwinton.

This should take care of the classic-under-win7-issue
Attachment #611536 - Attachment is obsolete: true
Comment on attachment 615332 [details] [diff] [review]
the fix (v2) - ui-r+ from bwinton.

Andreas:

Works perfectly!  Assigning myself for code review...

-Mike
Attachment #615332 - Attachment description: the fix (v2) → the fix (v2) - ui-r+ from bwinton.
Attachment #615332 - Flags: review?(mconley)
Comment on attachment 615332 [details] [diff] [review]
the fix (v2) - ui-r+ from bwinton.

Review of attachment 615332 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  Thanks Andreas!
Attachment #615332 - Flags: review?(mconley) → review+
Keywords: checkin-needed
Attachment #615332 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #615332 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/8f88b8cb546d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Keywords: checkin-needed
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/2698b91bc7f4
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.