[Instant messaging] The textboxes in the account settings for a GoogleTalk account have no labels

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Disability Access
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: MarcoZ, Assigned: florian)

Tracking

Trunk
Thunderbird 16.0

Thunderbird Tracking Flags

(thunderbird15 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
For screen readers, the password field and other fields except the "resource" field under "advanced" have no labels. Screen readers don't speak anything besides "textbox", so users don't know what to enter here.

If there are labels, they need to be properly associatd with the textboxes via the controls attribute. If they are provided via a different means, they're currently not accessible at all.
(Assignee)

Comment 1

5 years ago
Created attachment 631340 [details] [diff] [review]
Fix

Sorry about this, and thanks for reporting it! The labels did exist, but the field ids have been renamed at some point and I forgot to change the values of the control attributes.

I wonder if label elements with a control attribute that doesn't match any element id in the document could produce a warning in the error console, so that such trivial mistakes are caught faster.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #631340 - Flags: review?(mconley)
Comment on attachment 631340 [details] [diff] [review]
Fix

Review of attachment 631340 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and fixes the problem. Good catch.
Attachment #631340 - Flags: review?(mconley) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/comm-central/rev/9f92a04afea2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
(Assignee)

Comment 4

5 years ago
Comment on attachment 631340 [details] [diff] [review]
Fix

[Approval Request Comment]
Trivial accessibility fix for the chat feature.
Attachment #631340 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #631340 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/be270b5d532f
status-thunderbird15: --- → fixed
You need to log in before you can comment on or make changes to this bug.