739777 - Duplicate results can crash the site

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: MozTrap, defect)

Description

[Carl Meyer (:carljm)]

If somehow a duplicate result gets created for the same tester, environment, and included-test-case, that currently results in a 500 error. We should be robust against this.

Comment 1

[Cameron Dawson [:camd]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/27121339

Comment 2

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
I think these dupe results are being created by the dupe-included-caseversions cleanup code. That code should be fixed to not create dupe results (probably by just discarding any that aren't started yet if possible).

Comment 3

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to started in Pivotal Tracker

Comment 4

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
hey, I just was thinking that we'd love to get this onto staging tomorrow asap (because it blocks rebecca running the test run).  So would you merge this fix into 0.9?  Is that too hard to do now?

Comment 5

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
Here's the fix commit: https://github.com/mozilla/caseconductor/commit/613aab9d492ee28f9feb43b7b3c880afdc1ac849

Comment 6

[Cameron Dawson [:camd]]

Carl Meyer changed story state to delivered in Pivotal Tracker

Comment 7

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
makes sense.  thanks!!

Comment 8

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to accepted in Pivotal Tracker

Comment 9

[Matt Brandt [:mbrandt]]

Bumping to verified as [qa-] due to age of bug, shipped.