739801 - On first startup after a fresh install, the update timer manager skips checking for an update

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The culprit is

      if (Services.prefs.prefHasUserValue(prefLastUpdate)) {
        lastUpdateTime = Services.prefs.getIntPref(prefLastUpdate);
      }
      else {
        lastUpdateTime = now;

By setting lastUpdateTime = now, we skip the update-manifest check.

I'm not sure if it's intentional, but it's causing a problem for the following case
 - phone flashed at time X
 - phone powered on at time Y >> X
 - phone needs a gecko update

By setting the app.update.timerFirstInterval pref, I expect the first update check to happen after that timer expires.  However, because of initializing |lastUpdateTime = now;| we delay the first check until

  now + app.update.timerFirstInterval + app.update.interval

which is undesirable in this case.  I only want the phone to go app.update.timerFirstInterval before checking for an update that might fix a security vulnerability, e.g., discovered in the interval between X and Y.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Initialize the lastUpdateTime to 0 to make sure we check for an update on first startup after a fresh install (or profile clear)

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd6f8d1c7fe9

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/dd6f8d1c7fe9