Created attachment 609921 [details] [diff] [review]
Given that we traverse mSessionStorage, it seems like we should traverse mLocalStorage as well.
Also, with this patch, if I open and then immediately close the browser, all objects get cleaned up in one cycle collection. Without the patch, it takes two CCs.
Comment on attachment 609921 [details] [diff] [review]
You should also unlink localStorage.
Created attachment 609922 [details] [diff] [review]
Justin, this patch seems to fix at least some problems with shutdown CCs taking multiple cycles, so I'm wondering if it will fix some of the problems you saw with windows not getting killed quickly (which is why I was wondering what the bug number was so I can make this block that).
See bug 731419 comment 7. Those comments don't really belong in that bug...
Let me know if you need me to do any testing.
Even with this patch, a single cycle collection rarely cleans up everything. We still have a ways to go on that.