739810 - Cycle collector should traverse nsGlobalWindow::mLocalStorage

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Given that we traverse mSessionStorage, it seems like we should traverse mLocalStorage as well.

Also, with this patch, if I open and then immediately close the browser, all objects get cleaned up in one cycle collection. Without the patch, it takes two CCs.

Comment 1

[Olli Pettay [:smaug]]

Comment on attachment 609921 [details] [diff] [review]
patch

You should also unlink localStorage.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch v2

Thanks, fixed.

Comment 3

[Andrew McCreight [:mccr8]]

Justin, this patch seems to fix at least some problems with shutdown CCs taking multiple cycles, so I'm wondering if it will fix some of the problems you saw with windows not getting killed quickly (which is why I was wondering what the bug number was so I can make this block that).

Comment 4

[Justin Lebar (not reading bugmail)]

See bug 731419 comment 7.  Those comments don't really belong in that bug...

Let me know if you need me to do any testing.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d41b23cd2359

Even with this patch, a single cycle collection rarely cleans up everything. We still have a ways to go on that.

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/d41b23cd2359