739876 - Fix thumbnailer race condition and make thumbnailer generate multiple image sizes

Status: RESOLVED FIXED

(Pancake Graveyard :: Thumbnailer, defect)

Description

[Stuart Parmenter]

I did this in 3 patches -- one to remove the websnap code since it isn't being used and gets in the way, one to fix the race condition, and another to generate multiple images (and also made it spit out jpegs).  The patches apply in a specific order.

I have tested the image generation logic here in a stand-alone app, but have not verified that it uploads to S3 properly (my only concern is that I've added things that kind of look like query strings to the filename).

Comment 1

[Stuart Parmenter]

Attachment: 1 - fix race

this patch creates a unique temporary directory in which to work in -- is used more later

Comment 2

[Stuart Parmenter]

Attachment: 2 - remove websnap code

Comment 3

[Stuart Parmenter]

Attachment: 3 - Multisized-upload & convert to JPEG

This patch adds support to upload multiple sizes (and has temporary code to keep the straight key url with no size params working that should be removed eventually)

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

These look ok. The humbnailer-api also needs to be fixed so that it will check for the existence of these newly named files. I can integrate these patches in the code and move them to production.

Comment 5

[Stuart Parmenter]

this is fixed now