Fix thumbnailer race condition and make thumbnailer generate multiple image sizes

RESOLVED FIXED in M3

Status

Pancake
Thumbnailer
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Stuart Parmenter, Unassigned)

Tracking

unspecified
x86
Mac OS X

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
I did this in 3 patches -- one to remove the websnap code since it isn't being used and gets in the way, one to fix the race condition, and another to generate multiple images (and also made it spit out jpegs).  The patches apply in a specific order.

I have tested the image generation logic here in a stand-alone app, but have not verified that it uploads to S3 properly (my only concern is that I've added things that kind of look like query strings to the filename).
(Reporter)

Comment 1

6 years ago
Created attachment 609992 [details] [diff] [review]
1 - fix race

this patch creates a unique temporary directory in which to work in -- is used more later
(Reporter)

Comment 2

6 years ago
Created attachment 609993 [details] [diff] [review]
2 - remove websnap code
(Reporter)

Comment 3

6 years ago
Created attachment 609994 [details] [diff] [review]
3 - Multisized-upload & convert to JPEG

This patch adds support to upload multiple sizes (and has temporary code to keep the straight key url with no size params working that should be removed eventually)
These look ok. The humbnailer-api also needs to be fixed so that it will check for the existence of these newly named files. I can integrate these patches in the code and move them to production.
(Reporter)

Comment 5

6 years ago
this is fixed now
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.