739877 - downloadFavicon never releases its stream

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
java.lang.Throwable: Explicit termination method 'end' not called
	at dalvik.system.CloseGuard.open(CloseGuard.java:184)
	at java.util.zip.Inflater.<init>(Inflater.java:82)
	at java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:96)
	at java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:81)
	at libcore.net.http.HttpEngine.initContentStream(HttpEngine.java:515)
	at libcore.net.http.HttpEngine.readResponse(HttpEngine.java:808)
	at libcore.net.http.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:274)
	at libcore.net.http.HttpURLConnectionImpl.getHeaderField(HttpURLConnectionImpl.java:130)
	at java.net.URLConnection.getHeaderFieldInt(URLConnection.java:552)
	at java.net.URLConnection.getContentLength(URLConnection.java:320)
	at org.mozilla.gecko.Favicons$LoadFaviconTask.downloadFavicon(Favicons.java:290)
	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:369)
	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:226)
	at android.os.AsyncTask$2.call(AsyncTask.java:264)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
	at java.util.concurrent.FutureTask.run(FutureTask.java:137)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
	at java.lang.Thread.run(Thread.java:856)

Comment 1

[Sriram Ramasubramanian [:sriram]]

A changeset was landed by bnicholson on 28th, which changed the way Favicons are downloaded. After this, I don't see any such exception being caused. That particular piece of code does a getContent(), and so the entire stream is consumed. Please reopen if this still happens.