Last Comment Bug 739886 - prevent in-memory cache of collection names/ids from growing without bound
: prevent in-memory cache of collection names/ids from growing without bound
Status: VERIFIED FIXED
[qa?]
:
Product: Cloud Services
Classification: Client Software
Component: Server: Sync (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Ryan Kelly [:rfkelly]
:
Mentors:
Depends on:
Blocks: 727761
  Show dependency treegraph
 
Reported: 2012-03-27 21:24 PDT by Ryan Kelly [:rfkelly]
Modified: 2012-04-18 21:56 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch limiting size of in-memory collections cache (2.24 KB, patch)
2012-03-29 23:16 PDT, Ryan Kelly [:rfkelly]
telliott: review+
Details | Diff | Splinter Review

Description Ryan Kelly [:rfkelly] 2012-03-27 21:24:03 PDT

    
Comment 1 Ryan Kelly [:rfkelly] 2012-03-29 23:16:25 PDT
Created attachment 610808 [details] [diff] [review]
patch limiting size of in-memory collections cache

This patch adds a hard limit of 1000 items in the in-memory cache of collection names/ids.  Additional collections will continue to work, but will be slower because their details need to be looked up in the database on every request.
Comment 2 Toby Elliott [:telliott] 2012-03-30 10:09:23 PDT
Comment on attachment 610808 [details] [diff] [review]
patch limiting size of in-memory collections cache

Code is fine (no tests?), but my suspicion is that 1000 may end up too low and we may need to go to, say, 5000. Something to keep an eye on once we see the actual table size.
Comment 4 James Bonacci [:jbonacci] 2012-04-18 21:50:12 PDT
:telliott or :rfkelly - did you make a final decision on 1000 vs. 5000 here?
Comment 5 Ryan Kelly [:rfkelly] 2012-04-18 21:52:50 PDT
It's at 1000 in the code, I think it should be safe to leave at that for now.  Things will still work even if more than 1000 collections are created, they'll just be a bit slower.  And it's trivial to bump this number if required.

Note You need to log in before you can comment on or make changes to this bug.