Last Comment Bug 739905 - nsFind should use nsGkAtoms
: nsFind should use nsGkAtoms
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Henri Sivonen (:hsivonen)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-27 23:58 PDT by Henri Sivonen (:hsivonen)
Modified: 2012-03-28 14:00 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use nsGkAtoms (4.23 KB, patch)
2012-03-28 00:09 PDT, Henri Sivonen (:hsivonen)
bzbarsky: review+
Details | Diff | Splinter Review

Description Henri Sivonen (:hsivonen) 2012-03-27 23:58:22 PDT
nsFind creates atoms instead of using nsGkAtoms. It should use nsGkAtoms.
Comment 1 Henri Sivonen (:hsivonen) 2012-03-28 00:09:08 PDT
Created attachment 610032 [details] [diff] [review]
Use nsGkAtoms
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2012-03-28 01:57:47 PDT
Comment on attachment 610032 [details] [diff] [review]
Use nsGkAtoms

r=me
Comment 3 Henri Sivonen (:hsivonen) 2012-03-28 02:14:11 PDT
Thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/894c94e5a631
Comment 4 Ed Morley [:emorley] 2012-03-28 14:00:18 PDT
Please can you set the target milestone when landing on inbound, along the lines of http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing :-)

https://hg.mozilla.org/mozilla-central/rev/894c94e5a631

Note You need to log in before you can comment on or make changes to this bug.