The default bug view has changed. See this FAQ.

Port Bug 734371 [Adjust toolbar color for Australis]

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 14.0
All
Windows 7
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

5 years ago
The Australis theme is using a other toolbar background color. This Bug is for changing this.
(Assignee)

Updated

5 years ago
Blocks: 733854
(Assignee)

Comment 1

5 years ago
Created attachment 610183 [details] [diff] [review]
Patch

This patch changes the toolbox background color. It also changes the toolbox bottom border color following Bug 736954.
Please check also the status-bar. This has now also the new color like Firefox.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #610183 - Flags: ui-review?(nisses.mail)
Attachment #610183 - Flags: review?(nisses.mail)
(Assignee)

Comment 2

5 years ago
Created attachment 610184 [details]
Main window with new color

This screenshot shows also my first version of the new Australis toolbarbuttons (but this isn't the focus of this bug)
(Assignee)

Comment 3

5 years ago
Created attachment 610185 [details]
Address Book window
(Assignee)

Comment 4

5 years ago
Created attachment 610186 [details]
Compozer with AB sidebar
Comment on attachment 610183 [details] [diff] [review]
Patch

Looks great!
Attachment #610183 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 610183 [details] [diff] [review]
Patch

> border-bottom-color: #AABCCF;

Would it make sense to make this rgb(170,188,207);? (not sure what's the exact policy is, but it we set a lot of other colors like this).


With or without that fixed, r+ me.
Attachment #610183 - Flags: review?(nisses.mail) → review+
When I asked Shorlander about this on irc (because browser.css consists of lots of different hex, hsl and rgb) he said there is no policy:


andreasn: in browser.css, some colors are set as hex, others as rgb(x,x,x). Is there a policy for when to use what or something?

shorlander: andreasn: re: color format — no policy there. I usually use hex if there is no transparency and hsla for things with transparency. Although sometimes I use hsl if I have hsla somewhere else in the same ruleset.
(Assignee)

Comment 8

5 years ago
I let it in hex. Then it's easier to find and change it when FX is changing this because it's findable with an easy copy and paste search and no conversion is needed.
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/bfc54654f953
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.