Last Comment Bug 740035 - Port Bug 734371 [Adjust toolbar color for Australis]
: Port Bug 734371 [Adjust toolbar color for Australis]
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Windows 7
: -- normal (vote)
: Thunderbird 14.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks: 733854
  Show dependency treegraph
 
Reported: 2012-03-28 10:02 PDT by Richard Marti (:Paenglab)
Modified: 2012-03-30 17:28 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (8.12 KB, patch)
2012-03-28 10:11 PDT, Richard Marti (:Paenglab)
bugs: review+
bugs: ui‑review+
Details | Diff | Splinter Review
Main window with new color (87.79 KB, image/png)
2012-03-28 10:13 PDT, Richard Marti (:Paenglab)
no flags Details
Address Book window (33.33 KB, image/png)
2012-03-28 10:14 PDT, Richard Marti (:Paenglab)
no flags Details
Compozer with AB sidebar (40.85 KB, image/png)
2012-03-28 10:14 PDT, Richard Marti (:Paenglab)
no flags Details

Description Richard Marti (:Paenglab) 2012-03-28 10:02:12 PDT
The Australis theme is using a other toolbar background color. This Bug is for changing this.
Comment 1 Richard Marti (:Paenglab) 2012-03-28 10:11:30 PDT
Created attachment 610183 [details] [diff] [review]
Patch

This patch changes the toolbox background color. It also changes the toolbox bottom border color following Bug 736954.
Please check also the status-bar. This has now also the new color like Firefox.
Comment 2 Richard Marti (:Paenglab) 2012-03-28 10:13:49 PDT
Created attachment 610184 [details]
Main window with new color

This screenshot shows also my first version of the new Australis toolbarbuttons (but this isn't the focus of this bug)
Comment 3 Richard Marti (:Paenglab) 2012-03-28 10:14:23 PDT
Created attachment 610185 [details]
Address Book window
Comment 4 Richard Marti (:Paenglab) 2012-03-28 10:14:55 PDT
Created attachment 610186 [details]
Compozer with AB sidebar
Comment 5 Andreas Nilsson (:andreasn) 2012-03-30 06:12:33 PDT
Comment on attachment 610183 [details] [diff] [review]
Patch

Looks great!
Comment 6 Andreas Nilsson (:andreasn) 2012-03-30 06:28:11 PDT
Comment on attachment 610183 [details] [diff] [review]
Patch

> border-bottom-color: #AABCCF;

Would it make sense to make this rgb(170,188,207);? (not sure what's the exact policy is, but it we set a lot of other colors like this).


With or without that fixed, r+ me.
Comment 7 Andreas Nilsson (:andreasn) 2012-03-30 07:28:28 PDT
When I asked Shorlander about this on irc (because browser.css consists of lots of different hex, hsl and rgb) he said there is no policy:


andreasn: in browser.css, some colors are set as hex, others as rgb(x,x,x). Is there a policy for when to use what or something?

shorlander: andreasn: re: color format — no policy there. I usually use hex if there is no transparency and hsla for things with transparency. Although sometimes I use hsl if I have hsla somewhere else in the same ruleset.
Comment 8 Richard Marti (:Paenglab) 2012-03-30 08:28:11 PDT
I let it in hex. Then it's easier to find and change it when FX is changing this because it's findable with an easy copy and paste search and no conversion is needed.
Comment 9 Ryan VanderMeulen [:RyanVM] 2012-03-30 17:28:12 PDT
http://hg.mozilla.org/comm-central/rev/bfc54654f953

Note You need to log in before you can comment on or make changes to this bug.