740035 - Port Bug 734371 [Adjust toolbar color for Australis]

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The Australis theme is using a other toolbar background color. This Bug is for changing this.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Patch

This patch changes the toolbox background color. It also changes the toolbox bottom border color following Bug 736954.
Please check also the status-bar. This has now also the new color like Firefox.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Main window with new color

This screenshot shows also my first version of the new Australis toolbarbuttons (but this isn't the focus of this bug)

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Address Book window

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Compozer with AB sidebar

Comment 5

[Andreas Nilsson (:andreasn)]

Comment on attachment 610183 [details] [diff] [review]
Patch

Looks great!

Comment 6

[Andreas Nilsson (:andreasn)]

Comment on attachment 610183 [details] [diff] [review]
Patch

> border-bottom-color: #AABCCF;

Would it make sense to make this rgb(170,188,207);? (not sure what's the exact policy is, but it we set a lot of other colors like this).


With or without that fixed, r+ me.

Comment 7

[Andreas Nilsson (:andreasn)]

When I asked Shorlander about this on irc (because browser.css consists of lots of different hex, hsl and rgb) he said there is no policy:


andreasn: in browser.css, some colors are set as hex, others as rgb(x,x,x). Is there a policy for when to use what or something?

shorlander: andreasn: re: color format — no policy there. I usually use hex if there is no transparency and hsla for things with transparency. Although sometimes I use hsl if I have hsla somewhere else in the same ruleset.

Comment 8

[Richard Marti (:Paenglab)]

I let it in hex. Then it's easier to find and change it when FX is changing this because it's findable with an easy copy and paste search and no conversion is needed.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/bfc54654f953