740049 - Fix CSS warnings in TBPL

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: 1/2: Remove obsolete prefixed properties

These are mostly harmless.  The main reason I bothered is just to reduce console noise.

The first patch removes prefixed versions of properties that are now supported un-prefixed in all major browsers.  (The prefixed version is no longer supported in Gecko and generates a warning.)

The patch also fixes a minor syntax error (stray semicolon).

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: 2/2: remove unprefixed versions of non-standard properties

CSS transitions are not yet standardized, so the unprefixed property names are not yet supported and generate warnings.  If the syntax changes before standardization, the current code might be incompatible with future browsers.

On the other hand, if the syntax does not change, then leaving this code in place might *improve* compatibility with future browsers.  So I'm not sure if you want to take this patch or not.

This patch also removes non-moz versions of "outline-radius" because this property is Gecko-only and there are no plans to standardize it or to support it in other browsers:
https://developer.mozilla.org/en/CSS/-moz-outline-radius

Comment 2

[Arpad Borsos [:Swatinem]]

Comment on attachment 610197 [details] [diff] [review]
1/2: Remove obsolete prefixed properties

Review of attachment 610197 [details] [diff] [review]:
-----------------------------------------------------------------

Less vendor prefixes, yay. Thanks ;-)

Comment 3

[Arpad Borsos [:Swatinem]]

Comment on attachment 610201 [details] [diff] [review]
2/2: remove unprefixed versions of non-standard properties

Review of attachment 610201 [details] [diff] [review]:
-----------------------------------------------------------------

Well my personal opinion is to just stick with the not-yet-standard non-prefixed props, but I do not object to take this patch.

Comment 4

[Matt Brubeck (:mbrubeck)]

(In reply to Arpad Borsos (Swatinem) from comment #3)
> Well my personal opinion is to just stick with the not-yet-standard
> non-prefixed props, but I do not object to take this patch.

I'll just leave the transition-* properties alone then.  With luck they will be standardized soon.  I folded the outline-radius change into the first patch and landed them together:

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/fd9000bbbe12