Last Comment Bug 740191 - [Skia] Fix SkBlitRow_opts_arm.cpp for compiling with NEON and Thumb enabled.
: [Skia] Fix SkBlitRow_opts_arm.cpp for compiling with NEON and Thumb enabled.
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: George Wright (:gw280) (:gwright)
: Milan Sreckovic [:milan]
Depends on:
Blocks: 687187 skia-android
  Show dependency treegraph
Reported: 2012-03-28 16:01 PDT by George Wright (:gw280) (:gwright)
Modified: 2012-03-29 08:50 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix skblitrow (1.13 KB, patch)
2012-03-28 16:05 PDT, George Wright (:gw280) (:gwright)
matt.woodrow: review+
Details | Diff | Splinter Review

Description George Wright (:gw280) (:gwright) 2012-03-28 16:01:17 PDT
Currently if we try to compile with NEON and Thumb enabled, SkBlitRow_opts_arm.cpp fails to compile because we are using a conditional instruction without an if-then instruction.

This is being tracked upstream at
Comment 1 George Wright (:gw280) (:gwright) 2012-03-28 16:05:18 PDT
Created attachment 610341 [details] [diff] [review]
Fix skblitrow

Add a Thumb IT instruction before MOVEQ to fix compile error. Patch from
Comment 2 George Wright (:gw280) (:gwright) 2012-03-28 19:24:08 PDT
Comment 3 Matt Brubeck (:mbrubeck) 2012-03-29 08:50:01 PDT

Note You need to log in before you can comment on or make changes to this bug.