Closed Bug 740227 Opened 8 years ago Closed 8 years ago

Add TPS and TPS tests to make package-tests

Categories

(Testing Graveyard :: TPS, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla14

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file, 1 obsolete file)

In order to allow us to use the correct version of TPS and TPS tests when running TPS against on-commit builds in continuous integration, we should add both TPS and TPS tests to make package-tests, so we can download them in the tests bundle that corresponds to the build being tested.
Attached patch patch (obsolete) — Splinter Review
Attachment #611654 - Flags: review?(ted.mielczarek)
Comment on attachment 611654 [details] [diff] [review]
patch

Review of attachment 611654 [details] [diff] [review]:
-----------------------------------------------------------------

You should push this to try (once you've fixed it), then you can verify that the test packages contain what you expect.

::: testing/testsuite-targets.mk
@@ +290,4 @@
>  
>  ifndef UNIVERSAL_BINARY
>  PKG_STAGE = $(DIST)/test-package-stage
> +package-tests: stage-mochitest stage-reftest stage-xpcshell stage-jstests stage-jetpack stage-firebug stage-peptest stage-mozbase stage-tps

This list is getting kind of long. Can you reformat it with line continuations while you're here, like
package-tests: \
  stage-mochitest \
  ...
  stage-tps \
  $(NULL)
(note two-space indent)

@@ +346,5 @@
>  
> +stage-tps: make-stage-dir
> +	$(NSINSTALL) $(topsrcdir)/testing/tps $(PKG_STAGE)/tps
> +	$(NSINSTALL) $(topsrcdir)/services/sync/tps/extensions $(PKG_STAGE)/tps
> +	$(NSINSTALL) $(topsrcdir)/services/sync/tests/tps $(PKG_STAGE)/tps/tests

So uh, nsinstall doesn't work to recursively install directories on Windows. Sorry! If you look at how the other test suites package themselves you can copy/paste that code. It's mostly just using tar|untar to work around this.

@@ +363,4 @@
>    xpcshell-tests \
>    jstestbrowser \
>    peptest \
> +  package-tests make-stage-dir stage-mochitest stage-reftest stage-xpcshell stage-jstests stage-android stage-jetpack stage-firebug stage-peptest stage-mozbase stage-tps

These should probably be reformatted too.
Attachment #611654 - Flags: review?(ted.mielczarek) → review-
Assignee: nobody → jgriffin
Attached patch patch v0.2Splinter Review
Attachment #611654 - Attachment is obsolete: true
Whiteboard: [autoland-try]
Whiteboard: [autoland-try] → [autoland-in-queue]
Whiteboard: [autoland-in-queue] → [autoland-try]
Whiteboard: [autoland-try]
Try run for 6af3bdca2106 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6af3bdca2106
Results (out of 15 total builds):
    success: 13
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jgriffin@mozilla.com-6af3bdca2106
Autoland Patchset:
	Patches: 612669
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=775abd2769dc
Try run started, revision 775abd2769dc. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=775abd2769dc
Comment on attachment 612669 [details] [diff] [review]
patch v0.2

Try test packages in the try runs were all as expected.
Attachment #612669 - Flags: review?(ted.mielczarek)
Comment on attachment 612669 [details] [diff] [review]
patch v0.2

Review of attachment 612669 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one change

::: testing/testsuite-targets.mk
@@ +290,5 @@
>  
>  ifndef UNIVERSAL_BINARY
>  PKG_STAGE = $(DIST)/test-package-stage
> +package-tests: \
> +	stage-mochitest \

two-space indent here, not tabs.
Attachment #612669 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/28485be3fd5c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Try run for 775abd2769dc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=775abd2769dc
Results (out of 15 total builds):
    success: 13
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-775abd2769dc
 Timed out after 12 hours without completing.
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.