740310 - Grey background color for awesomebar tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Nightly Fennec 14.0a1 (2012-03-28)
Build:20120328115435
http://hg.mozilla.org/mozilla-central/rev/c3fd0768d46a
Device: Motorola Droid 2
OS: Android 2.3.3

Steps to reproduce:
1. Tap on the bookmark section on awesomebar
2. Move your finger over the bookmarked pages and release

Expected:
The background color of the bookmarks section remains white.

Actual
The background color of the bookmarks section become grey.

NOTE:Also the History/Top Sites tab has a grey background color until it is scrolled, when it becomes white.
Please see the attached screenshot

Comment 1

[Paul Feher]

Attachment: Device screenshot

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

I get the History turn all grey.

3/38/2012 Samsung Galaxy SII

1. tap on url bar
2. click on the history tab
3. long tap until you get the context menu
4. hit the android back button to dismiss the context menu

Expected: grey separation markers for the individual items
Actual: all grey background for the items

I think you need a bookmark header in order to see this in the bookmarks section?

Comment 3

[Tony Chung [:tchung]]

Attachment: screenshot on HTC Desire HD

Also reproduced, 4-3-2012 build, HTC Desire HD.

Comment 4

[Sriram Ramasubramanian [:sriram]]

I have a weird feeling that the default background for rows in ExpandableListView is causing the problems. But I'm not too sure about it yet. :(

We use android's default style of Widget.ListView.White. But Widget.ExpandableListView.White is not public.

This problem would go away, when we start using "textured blue" as in the tablets design. Do we want to switch to it now?

This is not happening to me in ICS. This happens to me with phones having their own overscroll behavior for lists.

Comment 5

[Tony Chung [:tchung]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #4)
> I have a weird feeling that the default background for rows in
> ExpandableListView is causing the problems. But I'm not too sure about it
> yet. :(
> 
> We use android's default style of Widget.ListView.White. But
> Widget.ExpandableListView.White is not public.
> 
> This problem would go away, when we start using "textured blue" as in the
> tablets design. Do we want to switch to it now?
> 
> This is not happening to me in ICS. This happens to me with phones having
> their own overscroll behavior for lists.

Confirmed, not reproducing on Galaxy Nexus, Android 4.0.2 build - 4/3 build

Comment 6

[Tony Chung [:tchung]]

Works: 3-27-2012
Breaks: 3-28-2012

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c3cb87871829&tochange=244991519f53

Comment 7

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

I don't know how "android:childDivider" was the culprit here. This particular attribute is available from API Level 1. :(

Removing this works fine. The default divider for the list is used, which is #E5E5E5.

Comment 8

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d77254a6dcf7

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/d77254a6dcf7

Comment 10

[Paul Feher]

Verified/fixed on:
Nightly Fennec 14.0a1 (2012-04-06)
Device: HTC Desire
OS: Android 2.2.2