Closed Bug 740349 Opened 14 years ago Closed 2 years ago

Tabs missing or tab count wrong in Safe Mode restart

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Version:
30 Branch
Platform:
x86
Windows 7
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: firstpeterfourten, Unassigned)

Details

I am a power user of tabs and have installed the Tab Groups Manager (see http://axel.my-sv.net/wiki/doku.php). For the purposes of simple description here, let's say I have 10 tab groups open with 10 tabs in each and an 11th tab group with only one tab in it (total 101 tabs are open). I'm in that 11th group and viewing the single tab. I select Restart with Add-Ons Disabled and FF restarts in Safe Mode. Any tabs from the current tab group (in this case, just the one) are reopened in a new Safe Mode window. None of the other tabs are shown or accessible in any way. That's fine. However, when I click X to exit that Safe Mode window that has only 1 tab, I get a warning "you are about to close 101 tabs. Are you sure you want to continue? The expected behavior that the number in that dialog box should be equal to the number of visible, accessible tabs. In this case that's one so the dialogue should not even be there, but if 2 tabs were visible it should ask about 2 tabs, not 102. A technically reasonable solution may also be to actually load all those tabs from all groups when restarting in Safe Mode, but I wouldn't recommend that.
This is a bug in FF and not TGM because the core bug (# of tabs present != # in warning dialogue) appears in safe mode with all add-ons disabled. The info about TGM is provided to help diagnose where in the code the bug might be and actionably understand why it's happening, so that it can be patched.
WBT, do you still see this when using current versions?
Flags: needinfo?(firstpeterfourten)
Yes, I'm still seeing this in FF30, and I've provided enough information in the original description that anybody should be able to check for this bug in any other version of his/her choosing, even including nightlies.
Flags: needinfo?(firstpeterfourten)
Version: 11 Branch → 30 Branch
Severity: normal → S3

(In reply to WBT from comment #3)

Yes, I'm still seeing this in FF30, and I've provided enough information in
the original description that anybody should be able to check for this bug
in any other version of his/her choosing, even including nightlies.

Can't say I understand, at least not how one would create this condition without the add-on.

Does this still reproduce for you?

Flags: needinfo?(firstpeterfourten)

While I'm no longer using that add-on, if there were any real prospects of making any progress on this 11-year old bug a developer/tester could start by installing it and verifying reproduction of the issue: that the number of tabs in the warning doesn't match the number of visible, accessible tabs. Using the extension was merely a quick and reliable way to trigger the real bug there.

Flags: needinfo?(firstpeterfourten)

If it doesn't happen without add-ons, I don't think there is an issue.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE

I think you've missed the point: it does happen without add-ons, in Safe Mode. There is clearly a bug there. The fastest route to reproduction is to use an add-on before restarting in safe mode with no add-ons. There are probably other ways to trigger it but they might be more intermittent, and folks using Safe Mode with all add-ons disabled might be rare enough to make duplicate reports less likely.

Mattias, James,
does this reproduce for you?

Flags: needinfo?(jamesrome)
Flags: needinfo?(bugzilla)

I can't test this, sorry

Flags: needinfo?(jamesrome)
Flags: needinfo?(bugzilla)
You need to log in before you can comment on or make changes to this bug.