74036 - Incorrect number of bookmarks moved with File Bookmark

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P1)

Description

[Becki Sanford]

From Bugzilla Helper:
User-Agent: Mozilla/4.72 [en] (X11; U; Linux 2.4.0-test10 i686)
BuildID:    Mozilla 0.8.1

When using Edit/File Bookmark menu item with multiple bookmarks selected, not
all of the items get moved to the new folder location.

Reproducible: Always
Steps to Reproduce:
1.Launch browser and select Bookmarks/Manage Bookmarks...
2.Select several bookmarks
3.Select Edit/File Bookmark and select a different folder location

Actual Results:  One or more of the bookmarks do not get moved.

Expected Results:  All of the bookmarks should be moved to the new folder
location.

Need to save the item selection before attempting to move the bookmarks because
the bookmarksTree.selectedItems.length will change each item through the
for-loop.

Comment 1

[Becki Sanford]

Attachment: Patch to bookmarks.js which saves the selection data

Comment 2

[Claudius Gayle]

changing OS/platform to All/All

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 29184 [details] [diff] [review]
Patch to bookmarks.js which saves the selection data

sr=[e-mail]

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

This code isn't actually used anymore, but it doesn't hurt to have disabled 
code not suck in case we ever turn it back on ;)

Patch checked in. Thanks!

Comment 5

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]