740378 - Invalid and insecure updateURL produces incompatible version message

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Mike Kaply [:mkaply]]

If the updateURL is invalid, rather than getting a message about that, the message simply says "this add-on is incompatible with this version of Firefox" even if maxVersion is correct.

An invalid update URL should either be ignored and the maxVersion honored, or it should produce a message that indicates what's actually going on.

Comment 1

[Dave Townsend [:mossop]]

You mean even if maxVersion is high enough it claims it's incompatible? Surprising since we shouldn't even be trying to ping the updateURL in that case.

What do you mean by "invalid" here?

Comment 2

[Mike Kaply [:mkaply]]

Yes, the maxVersion was totally correct.

The updateURL pointed to just a web page (in my case, it was a page that wasn't loading, but openDNS still returned a web page).

Here's an install.rdf that fails:

<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
xmlns:em="http://www.mozilla.org/2004/em-rdf#">

    <Description about="urn:mozilla:install-manifest">

        <em:id>[e-mail]</em:id>
        <em:name>CCK Custom</em:name>
        <em:version>11</em:version>
        <em:description>Custom Configuration</em:description>
        <em:updateURL>http://www.yahoo.com</em:updateURL>
        <em:targetApplication>
            <Description>
                <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
                <em:minVersion>10</em:minVersion>
                <em:maxVersion>*</em:maxVersion>
            </Description>
        </em:targetApplication>

        <em:unpack>true</em:unpack>

    </Description>

</RDF>

The error is:

"Could not be installed because it is not compatible with 11.0"

Comment 3

[Dave Townsend [:mossop]]

Oh I see, an insecure URL so yeah this is kind of a bad error message.

Comment 5

[Ben Bucksch (:BenB)]

Compare Tor bug https://trac.torproject.org/projects/tor/ticket/10682

Comment 6

[Andy McKay]

An insecure URL is no longer possible with WebExtensions. Not sure what error message an invalid URL throws anymore.

Comment 7

[Mike Kaply [:mkaply]]

Nothing about the updateURL prevents installation anymore.