Last Comment Bug 740389 - Clean up openTopWin and mark it as deprecated
: Clean up openTopWin and mark it as deprecated
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Firefox 14
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-29 08:44 PDT by Dão Gottwald [:dao]
Modified: 2012-03-30 13:06 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.45 KB, patch)
2012-03-29 08:44 PDT, Dão Gottwald [:dao]
gavin.sharp: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2012-03-29 08:44:17 PDT
Created attachment 610560 [details] [diff] [review]
patch

openTopWin calls openUILink with a fake event object that whereToOpenLink returns "current" for. It can just call openUILinkIn instead.
Comment 2 Ed Morley [:emorley] 2012-03-30 13:06:52 PDT
https://hg.mozilla.org/mozilla-central/rev/17da1d57097d

Note You need to log in before you can comment on or make changes to this bug.