740434 - [traceback] disabled accounts kick up ValueError: Unknown password hashing algorithm with django 1.4

Status: RESOLVED FIXED

(support.mozilla.org :: Users and Groups, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Traceback (most recent call last):

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.mozilla.org/kitsune/apps/sumo/decorators.py", line 19, in _checkssl
    return view_func(request, *args, **kwargs)

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django-session-csrf/session_csrf/__init__.py", line 127, in wrapper
    response = f(request, *args, **kw)

  File "/data/www/support.mozilla.org/kitsune/apps/users/views.py", line 40, in login
    form = handle_login(request)

  File "/data/www/support.mozilla.org/kitsune/apps/users/utils.py", line 22, in handle_login
    if form.is_valid():

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/forms/forms.py", line 124, in is_valid
    return self.is_bound and not bool(self.errors)

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/forms/forms.py", line 115, in _get_errors
    self.full_clean()

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/forms/forms.py", line 271, in full_clean
    self._clean_form()

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/forms/forms.py", line 299, in _clean_form
    self.cleaned_data = self.clean()

  File "/data/www/support.mozilla.org/kitsune/apps/users/forms.py", line 158, in clean
    password=password)

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/contrib/auth/__init__.py", line 45, in authenticate
    user = backend.authenticate(**credentials)

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/contrib/auth/backends.py", line 15, in authenticate
    if user.check_password(password):

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/contrib/auth/models.py", line 304, in check_password
    return check_password(raw_password, self.password, setter)

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/contrib/auth/hashers.py", line 42, in check_password
    hasher = get_hasher(algorithm)

  File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/contrib/auth/hashers.py", line 115, in get_hasher
    "setting?" % algorithm)

ValueError: Unknown password hashing algorithm 'PASSWORD_DISABLED'. Did you specify it in the PASSWORD_HASHERS setting?

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

This will go whenever the upgrade to django 1.4 can go.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Landed and deployed:

https://github.com/mozilla/kitsune/commit/11146bf481ec3c4783882b1186b09a0b1b7326bc

Filed a followup: bug 821043