Opening a previous conversation causes character encoding error

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Fallen, Assigned: florian)

Tracking

unspecified
Thunderbird 14.0
x86_64
Windows 7

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
STR:

1. Create a random conversation and write something
2. Close the conversation
3. Click on the contact, it will open the previous conversation

Results:

Error: The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must to be declared in the document or in the transfer protocol.
Source File: chrome://chat/content/conv.html
Line: 0
I started seeing this error message today too. I suspect we are seeing it now because bug 737022 has been fixed.
Created attachment 613633 [details] [diff] [review]
Patch

Here's a trivial fix. However this code depends on bug 713825 which was fixed in Mozilla 12, so we can't take this patch for Instantbird immediately.
Assignee: nobody → florian
Attachment #613633 - Flags: review?(clokep)
Comment on attachment 613633 [details] [diff] [review]
Patch

This change seems fine Florian.
Attachment #613633 - Flags: review?(clokep) → review+
http://hg.mozilla.org/comm-central/rev/8feb1f71d7c1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 613633 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: harmless error message in the error console each time an IM conversation is displayed.

I'm not sure if this meets the criteria for landing on comm-aurora as a chat polish fix or not, so requesting approval just in case it does, although I don't feel strongly either way.
Attachment #613633 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #613633 - Flags: approval-comm-aurora? → approval-comm-aurora+
The transplant of this failed, did it need something extra?
That's because it had already landed:

http://hg.mozilla.org/releases/comm-aurora/rev/15df6e2fb261
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.