740530 - Front end polish for videos

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Andy McKay]

Attachment: video editing

Once videos land...

- once a screenshot is uploaded, we set an element with a background style in the developer page pointing to the image. This works great with screenshots, but I'm not sure what to show with videos (see attached image). At this point it has not generated a screenshot. The current JS HTML element to: <div class="preview-thumb" background-image: url("blob:f12e7... Just set it to a standard placeholder image for videos?

- assuming images are going to be shown in the same place as images, we should probably put a nice video style arrow overlay on them. Clicking it can then open up the lightbox/modal/whatever and run the video in full size.

Comment 1

[Wil Clouser [:clouserw]]

Davor is doing the detail pages.  This seems like a cool project.

Andy says he'll be generating a thumbnail for the videos with Totem (today, I think) so that'll exist when you're fitting this in.

Comment 2

[Andy McKay]

On the second point, when I flipped to totem-video-thumbnailer it put little overlay on the image borders, eg: 

http://cl.ly/240A1M3K2N1e213O303V

That's probably enough, so forget the second point. Haven't seen anything in the command line to stop that.

Comment 3

[Andy McKay]

-r will remove those silly overlay borders if we want to do that.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to Andy McKay [:andym] from comment #3)
> -r will remove those silly overlay borders if we want to do that.

I like them. It makes it clear before you click on it that you're clicking on a video.

Comment 5

[Andy McKay]

It's inflexible though. I'd rather having nothing and we apply an overlay in our code.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/c1dc836
https://github.com/mozilla/zamboni/commit/c28fa4f
https://github.com/mozilla/zamboni/commit/a1e5bf7