740539 - Java may get incorrect page size

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

There's a possibility that the page size sent from gecko -> java in the Viewport:PageSize message is at a different zoom level than that currently in java. We need to account for this. Note that the setPageSize(float,float,float) method in GeckoLayerClient that is invoked by the compositor does this too; I just forgot it needs to happen in the Viewport:PageSize handler as well. This doesn't happen very often but it's visible in the dynamic-resolution strategy and makes the scrollbars change in size incorrectly. This is not easy to fix, unfortunately, since the zoom factor associated with the page size sent from browser.js is not necessarily the tab._zoom; it is really the resolution set on the cwu.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This patch is sort of what I had in mind, but it doesn't actually fix the problem I was seeing because the messageMetrics.getZoomFactor() is the zoom level stored in the tab in browser.js, not the display resolution on the pres shell (the two are the same unless we're using DynamicResolutionStrategy).

Comment 2

[Martijn Wargers (dead)]

Would this fix bug 735539 and/or bug 740005?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

No, this bug never manifest in current builds; it's only an issue for code that is not yet turned on.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Oh wait, what I just said was wrong. It could manifest in current code as well, but still wouldn't cause the bugs you refer to.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 610642 [details] [diff] [review]
Patch

I figure we might as well land this since it is technically a bug in current code.

Comment 6

[Chris Lord [:cwiiis]]

Comment on attachment 610642 [details] [diff] [review]
Patch

Review of attachment 610642 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5989e604e690

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/5989e604e690