Make the display port strategy preffable

RESOLVED FIXED in Firefox 14

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
Firefox 14
All
Android
Points:
---

Firefox Tracking Flags

(firefox14 fixed, blocking-fennec1.0 -)

Details

Attachments

(1 attachment)

Created attachment 610658 [details] [diff] [review]
Patch

Not sure if gfx.displayport.strategy is a good name for the pref, I just made it up.
Attachment #610658 - Flags: review?(chrislord.net)
blocking-fennec1.0: --- → ?

Comment 1

7 years ago
Comment on attachment 610658 [details] [diff] [review]
Patch

Review of attachment 610658 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: mobile/android/base/gfx/DisplayPortCalculator.java
@@ +33,5 @@
> +     * See the gfx.displayport.strategy pref in mobile/android/app/mobile.js to see the
> +     * mapping between ints and strategies.
> +     */
> +    static void setStrategy(int strategy) {
> +        Log.v(LOGTAG, "Setting strategy " + strategy);

Might be nice to output a string here, rather than just a number? Not a big deal.

I'd also say maybe Log.d, rather than v? Maybe even i? It's probably information we'd want to know if we start dynamically picking strategies and we're analysing peoples' logcats.
Attachment #610658 - Flags: review?(chrislord.net) → review+
(In reply to Chris Lord [:cwiiis] from comment #1)
> Might be nice to output a string here, rather than just a number? Not a big
> deal.

I changed it to print out the class name after setting it.

> I'd also say maybe Log.d, rather than v? Maybe even i? It's probably
> information we'd want to know if we start dynamically picking strategies and
> we're analysing peoples' logcats.

Good point, used Log.i

https://hg.mozilla.org/integration/mozilla-inbound/rev/931fe44e6326
status-firefox14: --- → fixed
Target Milestone: --- → Firefox 14

Comment 3

7 years ago
https://hg.mozilla.org/mozilla-central/rev/931fe44e6326
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
blocking-fennec1.0: ? → -
You need to log in before you can comment on or make changes to this bug.