740569 - Make the display port strategy preffable

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Not sure if gfx.displayport.strategy is a good name for the pref, I just made it up.

Comment 1

[Chris Lord [:cwiiis]]

Comment on attachment 610658 [details] [diff] [review]
Patch

Review of attachment 610658 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: mobile/android/base/gfx/DisplayPortCalculator.java
@@ +33,5 @@
> +     * See the gfx.displayport.strategy pref in mobile/android/app/mobile.js to see the
> +     * mapping between ints and strategies.
> +     */
> +    static void setStrategy(int strategy) {
> +        Log.v(LOGTAG, "Setting strategy " + strategy);

Might be nice to output a string here, rather than just a number? Not a big deal.

I'd also say maybe Log.d, rather than v? Maybe even i? It's probably information we'd want to know if we start dynamically picking strategies and we're analysing peoples' logcats.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Chris Lord [:cwiiis] from comment #1)
> Might be nice to output a string here, rather than just a number? Not a big
> deal.

I changed it to print out the class name after setting it.

> I'd also say maybe Log.d, rather than v? Maybe even i? It's probably
> information we'd want to know if we start dynamically picking strategies and
> we're analysing peoples' logcats.

Good point, used Log.i

https://hg.mozilla.org/integration/mozilla-inbound/rev/931fe44e6326

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/931fe44e6326