Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add conversion functions between SurfaceFormats and ImageFormats

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gw280, Assigned: gw280)

Tracking

unspecified
mozilla14
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It'd be nice for gfx2DGlue to have conversion functions for converting between these two types.
Created attachment 610682 [details] [diff] [review]
Bug 740570 - Add conversion functions between SurfaceFormats and ImageFormats
Attachment #610682 - Flags: review?(jmuizelaar)
(Assignee)

Updated

5 years ago
Blocks: 740580
(Assignee)

Updated

5 years ago
Attachment #610682 - Flags: review?(jmuizelaar) → review?(bas.schouten)
Comment on attachment 610682 [details] [diff] [review]
Bug 740570 - Add conversion functions between SurfaceFormats and ImageFormats

Review of attachment 610682 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this works :) Although the format->content->format trick makes me a little icky :)

::: gfx/thebes/gfx2DGlue.h
@@ +208,5 @@
> +}
> +
> +inline gfxASurface::gfxImageFormat ImageFormatForSurfaceFormat(SurfaceFormat aFormat)
> +{
> +  return gfxASurface::FormatFromContent(mozilla::gfx::ContentForFormat(aFormat));

No need for mozilla::gfx.
Attachment #610682 - Flags: review?(bas.schouten) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7bf4d83eab6
Oh, oops, I only just saw the comment re. mozilla::gfx...

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f7bf4d83eab6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.