Uninitialized value used in GLContext::UploadSurfaceToTexture

RESOLVED WORKSFORME

Status

()

Core
Graphics
RESOLVED WORKSFORME
6 years ago
5 years ago

People

(Reporter: ajuma, Unassigned)

Tracking

({valgrind})

Trunk
ARM
Android
valgrind
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
sewardj found another instance of us using an uninitialized value:

Conditional jump or move depends on uninitialised value(s)
   at 0x3603ADA6: mozilla::gl::GLContext::UploadSurfaceToTexture(gfxASurface*, nsIntRegion const&, unsigned int&, bool, nsIntPoint const&, bool) (GLContext.cpp:2170)
   by 0x360405D3: mozilla::gl::TextureImageEGL::DirectUpdate(gfxASurface*, nsIntRegion const&, nsIntPoint const&) (GLContextProviderEGL.cpp:1059)
   by 0x3603B3EF: mozilla::gl::TiledTextureImage::DirectUpdate(gfxASurface*, nsIntRegion const&, nsIntPoint const&) (GLContext.cpp:929)
   by 0x360324F9: mozilla::layers::ShadowBufferOGL::DirectUpdate(gfxASurface*, nsIntRegion&) (ThebesLayerOGL.cpp:942)
   by 0x36032611: mozilla::layers::ShadowBufferOGL::Upload(gfxASurface*, nsIntRegion const&, nsIntRect const&, nsIntPoint const&, bool, nsIntRegion&) (ThebesLayerOGL.cpp:976)
   by 0x36032905: mozilla::layers::ShadowThebesLayerOGL::Swap(mozilla::layers::ThebesBuffer const&, nsIntRegion const&, mozilla::layers::OptionalThebesBuffer*, nsIntRegion*, mozilla::layers::OptionalThebesBuffer*, nsIntRegion*) (ThebesLayerOGL.cpp:1230)
   by 0x36038CDD: mozilla::layers::ShadowLayersParent::RecvUpdate(InfallibleTArray<mozilla::layers::Edit> const&, bool const&, InfallibleTArray<mozilla::layers::EditReply>*) (ShadowLayersParent.cpp:334)
   by 0x35F11EDF: mozilla::layers::PLayersParent::OnMessageReceived(IPC::Message const&, IPC::Message*&) (PLayersParent.cpp:318)
   by 0x35F0E06F: mozilla::layers::PCompositorParent::OnMessageReceived(IPC::Message const&, IPC::Message*&) (PCompositorParent.cpp:338)
   by 0x35EE85E5: mozilla::ipc::SyncChannel::OnDispatchMessage(IPC::Message const&) (SyncChannel.cpp:175)
   by 0x35EE71B5: mozilla::ipc::RPCChannel::OnMaybeDequeueOne() (RPCChannel.cpp:432)
   by 0x35EE4817: RunnableMethod<mozilla::ipc::RPCChannel, bool (mozilla::ipc::RPCChannel::*)(), Tuple0>::Run() (tuple.h:383)
I'll try to find the origin of the uninitialised value (a stack
or heap allocation).  I don't have STR for it at the moment, tho.
This happened a second time, but I still don't know how to repro
at will.  Ali's IRC suggestion of using a wide web site .. I can
try that if you have something specific in mind .. ?
I can't repro this on m-c Android now.  Proposing to close.  OK ?
Keywords: valgrind
Resolving WFM per previous comment - we can always file new bugs for issues that crop up again.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.