740599 - update staging release config files

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Hal Wine [:hwine] use NI!]

As normal part of new-release-person-hazing, bring all staging_release*py files up to date

Comment 1

[Hal Wine [:hwine] use NI!]

Attachment: changes to bring staging configs up to date

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 610686 [details] [diff] [review]
changes to bring staging configs up to date

Cool.  I think these look good for the most part.
The below need fixing:

>diff --git a/mozilla/staging_release-fennec-mozilla-beta.py b/mozilla/staging_release-fennec-mozilla-beta.py
>--- a/mozilla/staging_release-fennec-mozilla-beta.py
>+++ b/mozilla/staging_release-fennec-mozilla-beta.py

*snip*

>-# Staging config
>-releaseConfig['build_tools_repo_path'] = "users/stage-ffxbld/tools"
>-releaseConfig['skip_release_download'] = True
> releaseConfig['enableSigningAtBuildTime'] = False
> releaseConfig['enablePartialMarsAtBuildTime'] = False

Is there a reason you're removing these three lines from the staging config?
I think they need to stay.

>diff --git a/mozilla/staging_release-fennec-mozilla-esr10.py b/mozilla/staging_release-fennec-mozilla-esr10.py
>--- a/mozilla/staging_release-fennec-mozilla-esr10.py
>+++ b/mozilla/staging_release-fennec-mozilla-esr10.py
>@@ -22,12 +22,12 @@ releaseConfig['buildNumber']         = 1
> releaseConfig['baseTag']             = 'FENNEC_10_0_3esr'
> #  Old version info
> releaseConfig['oldVersion']          = '10.0.2esr'
>-releaseConfig['oldAppVersion']       = '10.0.2'
>+releaseConfig['oldAppVersion']       = releaseConfig['oldVersion']

a) I think we want oldAppVersion to be 10.0.2 (without the esr), which means the release config needs fixing.
b) I don't think we actually reference this oldAppVersion at the moment, so nothing bad will have happened.
c) I'd be ok with either bumping both fennec esr10 release configs to have an oldAppVersion of 10.0.2, or removing all releaseConfig['old*'] from the esr10 (or all) fennec release configs.
The latter would be cleaner, and will probably not cause any checkconfig issues, but the former would have the lowest footprint and least risk.

>-# Staging config
>-releaseConfig['build_tools_repo_path'] = "users/stage-ffxbld/tools"
>-releaseConfig['skip_release_download'] = True

I think we want to keep these still.

>diff --git a/mozilla/staging_release-fennec-mozilla-release.py b/mozilla/staging_release-fennec-mozilla-release.py
>--- a/mozilla/staging_release-fennec-mozilla-release.py
>+++ b/mozilla/staging_release-fennec-mozilla-release.py

*snip*

>-# Staging config
>-releaseConfig['build_tools_repo_path'] = "users/stage-ffxbld/tools"
>-releaseConfig['skip_release_download'] = True

Here too.

r-'ing for removing the staging config lines.

Comment 3

[Hal Wine [:hwine] use NI!]

Attachment: revised per Aki's comments, see comment

restored lines improperly included in block move, given scope of current work and fact that _both_ release & staging versions of staging_release-fennec-mozilla-esr10.py appear incorrect, removing that from this bug - will file separate bug on that

Comment 4

[Hal Wine [:hwine] use NI!]

Comment on attachment 610722 [details] [diff] [review]
revised per Aki's comments, see comment

http://hg.mozilla.org/build/buildbot-configs/rev/63811c8bd2e8

Comment 5

[Armen [:armenzg]]

This got merged to production this morning.