Move rule view copy code into CssRuleView.jsm

RESOLVED FIXED in Firefox 14

Status

RESOLVED FIXED
7 years ago
8 months ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

13 Branch
Firefox 14

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
... because that's where it belongs.
(Assignee)

Comment 1

7 years ago
Created attachment 610708 [details] [diff] [review]
move the event handling to CssRuleView.jsm

There's no sense keeping all the event handling for the rule view anywhere but CssRuleView.jsm.  This is needed for the sidebar creation refactoring that's underway.
Attachment #610708 - Flags: review?(paul)
Attachment #610708 - Flags: feedback?(mratcliffe)
Comment on attachment 610708 [details] [diff] [review]
move the event handling to CssRuleView.jsm

Looks good to me. At some point we should also separate the shared stylesheets, DTD & properties files. The localizers have complained about duplicate strings even though they are used in 2 different tools.
Attachment #610708 - Flags: feedback?(mratcliffe) → feedback+
Comment on attachment 610708 [details] [diff] [review]
move the event handling to CssRuleView.jsm

Review of attachment 610708 [details] [diff] [review]:
-----------------------------------------------------------------

r+, just a nit.

::: browser/devtools/styleinspector/CssRuleView.jsm
@@ +738,5 @@
> +    delete this._boundCopyProperty;
> +
> +    this._propertyValueItem.removeEventListener("command", this._boundCopyPropertyValue);
> +    delete this._boundCopyProperrtyValue;
> +

_boundCopyProperrtyValue <- extra 'r'
Attachment #610708 - Flags: review?(paul) → review+
(Assignee)

Comment 4

7 years ago
Created attachment 611519 [details] [diff] [review]
typo fix
Attachment #610708 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Whiteboard: [land-in-fx-team]

Updated

7 years ago
Blocks: 707809
(Assignee)

Comment 5

7 years ago
https://hg.mozilla.org/integration/fx-team/rev/f47780831b31
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f47780831b31
Status: NEW → RESOLVED
Last Resolved: 7 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.