Closed Bug 740615 Opened 8 years ago Closed 8 years ago

Move rule view copy code into CssRuleView.jsm

Categories

(DevTools :: Inspector, defect)

13 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 14

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

Attachments

(1 file, 1 obsolete file)

... because that's where it belongs.
There's no sense keeping all the event handling for the rule view anywhere but CssRuleView.jsm.  This is needed for the sidebar creation refactoring that's underway.
Attachment #610708 - Flags: review?(paul)
Attachment #610708 - Flags: feedback?(mratcliffe)
Comment on attachment 610708 [details] [diff] [review]
move the event handling to CssRuleView.jsm

Looks good to me. At some point we should also separate the shared stylesheets, DTD & properties files. The localizers have complained about duplicate strings even though they are used in 2 different tools.
Attachment #610708 - Flags: feedback?(mratcliffe) → feedback+
Comment on attachment 610708 [details] [diff] [review]
move the event handling to CssRuleView.jsm

Review of attachment 610708 [details] [diff] [review]:
-----------------------------------------------------------------

r+, just a nit.

::: browser/devtools/styleinspector/CssRuleView.jsm
@@ +738,5 @@
> +    delete this._boundCopyProperty;
> +
> +    this._propertyValueItem.removeEventListener("command", this._boundCopyPropertyValue);
> +    delete this._boundCopyProperrtyValue;
> +

_boundCopyProperrtyValue <- extra 'r'
Attachment #610708 - Flags: review?(paul) → review+
Attached patch typo fixSplinter Review
Attachment #610708 - Attachment is obsolete: true
Whiteboard: [land-in-fx-team]
Blocks: 707809
https://hg.mozilla.org/integration/fx-team/rev/f47780831b31
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f47780831b31
Status: NEW → RESOLVED
Closed: 8 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.