Closed
Bug 740615
Opened 12 years ago
Closed 12 years ago
Move rule view copy code into CssRuleView.jsm
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 14
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
Attachments
(1 file, 1 obsolete file)
30.96 KB,
patch
|
Details | Diff | Splinter Review |
... because that's where it belongs.
Assignee | ||
Comment 1•12 years ago
|
||
There's no sense keeping all the event handling for the rule view anywhere but CssRuleView.jsm. This is needed for the sidebar creation refactoring that's underway.
Attachment #610708 -
Flags: review?(paul)
Attachment #610708 -
Flags: feedback?(mratcliffe)
Comment 2•12 years ago
|
||
Comment on attachment 610708 [details] [diff] [review] move the event handling to CssRuleView.jsm Looks good to me. At some point we should also separate the shared stylesheets, DTD & properties files. The localizers have complained about duplicate strings even though they are used in 2 different tools.
Attachment #610708 -
Flags: feedback?(mratcliffe) → feedback+
Comment 3•12 years ago
|
||
Comment on attachment 610708 [details] [diff] [review] move the event handling to CssRuleView.jsm Review of attachment 610708 [details] [diff] [review]: ----------------------------------------------------------------- r+, just a nit. ::: browser/devtools/styleinspector/CssRuleView.jsm @@ +738,5 @@ > + delete this._boundCopyProperty; > + > + this._propertyValueItem.removeEventListener("command", this._boundCopyPropertyValue); > + delete this._boundCopyProperrtyValue; > + _boundCopyProperrtyValue <- extra 'r'
Attachment #610708 -
Flags: review?(paul) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #610708 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f47780831b31
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f47780831b31
Status: NEW → RESOLVED
Closed: 12 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•