740615 - Move rule view copy code into CssRuleView.jsm

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Camp (:dcamp)]

... because that's where it belongs.

Comment 1

[Dave Camp (:dcamp)]

Attachment: move the event handling to CssRuleView.jsm

There's no sense keeping all the event handling for the rule view anywhere but CssRuleView.jsm.  This is needed for the sidebar creation refactoring that's underway.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 610708 [details] [diff] [review]
move the event handling to CssRuleView.jsm

Looks good to me. At some point we should also separate the shared stylesheets, DTD & properties files. The localizers have complained about duplicate strings even though they are used in 2 different tools.

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 610708 [details] [diff] [review]
move the event handling to CssRuleView.jsm

Review of attachment 610708 [details] [diff] [review]:
-----------------------------------------------------------------

r+, just a nit.

::: browser/devtools/styleinspector/CssRuleView.jsm
@@ +738,5 @@
> +    delete this._boundCopyProperty;
> +
> +    this._propertyValueItem.removeEventListener("command", this._boundCopyPropertyValue);
> +    delete this._boundCopyProperrtyValue;
> +

_boundCopyProperrtyValue <- extra 'r'

Comment 4

[Dave Camp (:dcamp)]

Attachment: typo fix

Comment 5

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/f47780831b31

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f47780831b31