Closed
Bug 740680
Opened 12 years ago
Closed 12 years ago
TB-IM: Remove "#!" from copying Twitter's tweet url
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: tetsuharu, Assigned: tetsuharu)
Details
Attachments
(1 file)
1.03 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
Remove "#!" from copying Twitter's tweet url.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #610778 -
Flags: review?
Comment 2•12 years ago
|
||
Does this cause some sort of issue? If you go to the URL as given in your patch it will simply redirect you to the one with #! in it. Why do you wish to remove this?
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #2) > Does this cause some sort of issue? If you go to the URL as given in your > patch it will simply redirect you to the one with #! in it. Why do you wish > to remove this? Currently, Twitter website provides tweet urls that it removes "#!" from urls. e.g. https://twitter.com/mozilla/statuses/184746891953700865 -> Embed this tweet -> link.
Comment 4•12 years ago
|
||
Comment on attachment 610778 [details] [diff] [review] proposed patch Hmmm...that it does. I hate the way Twitter has their website set up... Anyway, this change looks fine to me then. :)
Attachment #610778 -
Flags: review? → review+
Updated•12 years ago
|
Assignee: nobody → saneyuki.s.snyk
Severity: normal → trivial
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #4) > Comment on attachment 610778 [details] [diff] [review] > proposed patch > > Hmmm...that it does. I hate the way Twitter has their website set up... > > Anyway, this change looks fine to me then. :) This technique containing "#!" in url is called hashbang in some locations. But this has a problem about maintainability. (e.g. http://adactio.com/journal/4602/) We should follow the behavior if Twitter provides a normal url without "#!".
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 6•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/381736b3d3b9
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in
before you can comment on or make changes to this bug.
Description
•