The default bug view has changed. See this FAQ.

TB-IM: Remove "#!" from copying Twitter's tweet url

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Instant Messaging
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tetsuharu, Assigned: tetsuharu)

Tracking

Trunk
Thunderbird 14.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Remove "#!" from copying Twitter's tweet url.
Created attachment 610778 [details] [diff] [review]
proposed patch
Attachment #610778 - Flags: review?
Does this cause some sort of issue? If you go to the URL as given in your patch it will simply redirect you to the one with #! in it. Why do you wish to remove this?
(In reply to Patrick Cloke [:clokep] from comment #2)
> Does this cause some sort of issue? If you go to the URL as given in your
> patch it will simply redirect you to the one with #! in it. Why do you wish
> to remove this?

Currently, Twitter website provides tweet urls that it removes "#!" from urls.
e.g. https://twitter.com/mozilla/statuses/184746891953700865 -> Embed this tweet -> link.
Comment on attachment 610778 [details] [diff] [review]
proposed patch

Hmmm...that it does. I hate the way Twitter has their website set up...

Anyway, this change looks fine to me then. :)
Attachment #610778 - Flags: review? → review+
Assignee: nobody → saneyuki.s.snyk
Severity: normal → trivial
Status: NEW → ASSIGNED
(In reply to Patrick Cloke [:clokep] from comment #4)
> Comment on attachment 610778 [details] [diff] [review]
> proposed patch
> 
> Hmmm...that it does. I hate the way Twitter has their website set up...
> 
> Anyway, this change looks fine to me then. :)

This technique containing "#!" in url is called hashbang in some locations.
But this has a problem about maintainability. (e.g. http://adactio.com/journal/4602/)
We should follow the behavior if Twitter provides a normal url without "#!".
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/381736b3d3b9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.