Last Comment Bug 740680 - TB-IM: Remove "#!" from copying Twitter's tweet url
: TB-IM: Remove "#!" from copying Twitter's tweet url
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 14.0
Assigned To: Tetsuharu OHZEKI [:tetsuharu] [UTC+9]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-29 17:59 PDT by Tetsuharu OHZEKI [:tetsuharu] [UTC+9]
Modified: 2012-03-30 17:28 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
proposed patch (1.03 KB, patch)
2012-03-29 18:01 PDT, Tetsuharu OHZEKI [:tetsuharu] [UTC+9]
clokep: review+
Details | Diff | Review

Description Tetsuharu OHZEKI [:tetsuharu] [UTC+9] 2012-03-29 17:59:34 PDT
Remove "#!" from copying Twitter's tweet url.
Comment 1 Tetsuharu OHZEKI [:tetsuharu] [UTC+9] 2012-03-29 18:01:22 PDT
Created attachment 610778 [details] [diff] [review]
proposed patch
Comment 2 Patrick Cloke [:clokep] 2012-03-29 18:02:19 PDT
Does this cause some sort of issue? If you go to the URL as given in your patch it will simply redirect you to the one with #! in it. Why do you wish to remove this?
Comment 3 Tetsuharu OHZEKI [:tetsuharu] [UTC+9] 2012-03-29 18:29:19 PDT
(In reply to Patrick Cloke [:clokep] from comment #2)
> Does this cause some sort of issue? If you go to the URL as given in your
> patch it will simply redirect you to the one with #! in it. Why do you wish
> to remove this?

Currently, Twitter website provides tweet urls that it removes "#!" from urls.
e.g. https://twitter.com/mozilla/statuses/184746891953700865 -> Embed this tweet -> link.
Comment 4 Patrick Cloke [:clokep] 2012-03-29 18:41:15 PDT
Comment on attachment 610778 [details] [diff] [review]
proposed patch

Hmmm...that it does. I hate the way Twitter has their website set up...

Anyway, this change looks fine to me then. :)
Comment 5 Tetsuharu OHZEKI [:tetsuharu] [UTC+9] 2012-03-29 18:54:23 PDT
(In reply to Patrick Cloke [:clokep] from comment #4)
> Comment on attachment 610778 [details] [diff] [review]
> proposed patch
> 
> Hmmm...that it does. I hate the way Twitter has their website set up...
> 
> Anyway, this change looks fine to me then. :)

This technique containing "#!" in url is called hashbang in some locations.
But this has a problem about maintainability. (e.g. http://adactio.com/journal/4602/)
We should follow the behavior if Twitter provides a normal url without "#!".
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-03-30 17:28:46 PDT
http://hg.mozilla.org/comm-central/rev/381736b3d3b9

Note You need to log in before you can comment on or make changes to this bug.