Starting a conversation with an IRC contact does not remove it from the online contacts list

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jb Piacentino, Assigned: clokep)

Tracking

13 Branch
Thunderbird 14.0
Bug Flags:
in-testsuite ?

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
STR:

- Click on an IRC online contact
- The last conversation w/ this contact is displayed
- Click 'Start a new conversation'

Current results
- A new conversation with the name of the contact appears in the conversation list
- Contact name remains listed in Online contacts
- The last conversation remains displayed


Expected results
- The contact name should move from 'Online contacts' to 'Conversations'
- The newly created conversation should be displayed, ready to start
There are 2 different things in this description:
- starting a conversation with an IRC contact doesn't remove the contact from the list of online contact. We will handle this here, I know clokep has a fix already.
- automatically selecting the new conversation when it is started using the mouse even when the contact wasn't selected. I filed bug 740765 on this.
Assignee: nobody → clokep
Summary: Start a new conversation in IRC does not open the conversation → Starting a conversation with an IRC contact does not remove it from the online contacts list
(Assignee)

Comment 2

5 years ago
Created attachment 610856 [details] [diff] [review]
Set the buddy property of the conversation

(In reply to Florian Quèze from comment #1)
> - starting a conversation with an IRC contact doesn't remove the contact
> from the list of online contact. We will handle this here, I know clokep has
> a fix already.

The fix is to set the buddy field of the conversation (if we have the buddy in our buddy list) to properly link the conversation & buddy.
Attachment #610856 - Flags: review?(florian)
Comment on attachment 610856 [details] [diff] [review]
Set the buddy property of the conversation

Thanks for providing a fix so quickly!
Attachment #610856 - Flags: review?(florian) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/c994cf6558da

Also, to make life easier for those checking in patches on your behalf, please follow the directions below for any future patches you submit. Thanks!
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 610856 [details] [diff] [review]
Set the buddy property of the conversation

[Approval Request Comment]
User impact if declined: quite visible brokenness when starting a private conversation with an IRC contact.
Attachment #610856 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #610856 - Flags: approval-comm-aurora? → approval-comm-aurora+
Checked in:

http://hg.mozilla.org/releases/comm-aurora/rev/8deaee43b177
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.