74078 - cast from void * to char breaks hpux, aix & OS/2

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[cls]

Naving, your checkin of net_pop3_remove_messages_marked_delete() in
nsPop3Protocol.cpp caused 3 of our ports tinderboxes to go red tonight.  The
error messages were along the lines of:

"/builds/tinderbox/SeaMonkey/AIX_4.3_Clobber/mozilla/mailnews/local/src/nsPop3Protocol.cpp",
line 114.35: 1540-225: (S) "char" is too small to hold a value of type "void*".

I made the following change to the code in hopes of making the trees turn green
again but there's an ongoing debate on #mozilla as to whether either the fix or
the original code would 

Here's the core of my change.

-
char valueChar = (char) he->value;
+
char valueChar = '\0';
+    if (he->value)
+
  nsCRT::memcpy(&valueChar, he->value, sizeof(char));
do what was desired since sizeof char != sizeof void *.

Comment 1

[Navin Gupta]

Thanks for fixing the bustage

Comment 2

[cls]

Oops, I meant to update this before I went to bed last night.  Turns out that my
controversial fix was the wrong thing to do after all.  We ended up using Brad
Roberts' fix of replacing

char valueChar = (char) he->value;

with

char valueChar = (char)(long)he->value;

Comment 3

[esther]

Navin, please verify this

Comment 4

[Navin Gupta]

verified