Closed Bug 740961 Opened 8 years ago Closed 8 years ago

Debug logging is turned on in NSSBridge

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Unassigned)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
We're not using this yet, but when we do we should make sure the logging is hidden.
Attachment #611022 - Flags: review?(mark.finkle)
Comment on attachment 611022 [details] [diff] [review]
Patch

What is the goal of turning this on? How long should we leave it on? What kind of data is shown?
Attachment #611022 - Attachment is patch: true
We're turning it off. I left it in from my original debugging.
Attachment #611022 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/41293c7b7234
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Was it intentional to still have the printf in this code even when DEBUG is not defined? This will prevent the code and messages from being compiled out.

...also, log messages like "xxx Decoded : binaryjunk" aren't very useful for users of your code, even if they want the debug output :-/
Nope. I don't even remember adding that... 

The logging that's here is things I needed while debugging this. I admit that some base64 encoded binaryjunk doesn't seem very readable, but it was helpful to me to see something.
You need to log in before you can comment on or make changes to this bug.